FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-143672: convert the struct module to AC by skirpichev · Pull Request #143673 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-143672: convert the struct module to AC - #143673

Closed
skirpichev wants to merge 9 commits into
python:mainfrom
skirpichev:struct-AC/143672
ConversationCommits (9)ChecksFiles changed
Closed

gh-143672: convert the struct module to AC#143673
skirpichev wants to merge 9 commits into
python:mainfrom
skirpichev:struct-AC/143672

Conversation

skirpichev commented Jan 11, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Jan 11, 2026
Closed
skirpichev mentioned this pull request Jan 11, 2026
Merged
skirpichev marked this pull request as ready for review January 11, 2026 02:49
sobolevn reviewed Jan 11, 2026
View reviewed changes
Comment thread Modules/_struct.c

See help(struct) for more on format strings.
Return a new Struct object which writes and reads binary data according
to the format string. See help(struct) for more on format strings.

sobolevn Jan 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

what is the reason for newline -> double space change? I was not aware that this is required.

skirpichev Jan 11, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

In some docstrings "See help(struct) for more on format strings." was separated to a new paragraph. In some - no. Looks as a waste of space, especially in help(struct) output.

Comment thread Modules/_struct.c Outdated
/
*args: array

Pack args to the writtable buffer according to the format self.

sobolevn Jan 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
Pack args to the writtable buffer according to the format self.
Pack args to the writtable buffer according to the struct's format string.

skirpichev Jan 11, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Too long. Beware @permit_long_summary.

Comment thread Modules/_struct.c Outdated
strings.");
*args: array

Return a bytes object with args, packed according the format self.

sobolevn Jan 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
Return a bytes object with args, packed according the format self.
Return a bytes object with args, packed according the struct's format string.

skirpichev commented Jan 11, 2026

Copy link
Copy Markdown
Member Author

BTW, I'm not attached to docstrings.

IMO, they aren't good and I tried to improve that. But I can just revert that stuff and keep old doctsrings almost literally (summary line is required, though).

serhiy-storchaka reviewed Jan 15, 2026
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sorry, I have not noticed this PR and created an alternative PR #143857.

There are some differences between two PRs, and I had reasons for all changes. We can now gradually convert your PR into my PR by applying one change at a time or just take my PR.

See the difference between the PRs: https://github.com/skirpichev/cpython/pull/14/changes .

Comment thread Modules/_struct.c
Struct.pack_into as s_pack_into

buffer: Py_buffer
offset: Py_ssize_t

serhiy-storchaka Jan 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

There is a subtle behavior difference here (IndexError vs OverflowError). I leave this for other issue.

Comment thread Modules/_struct.c Outdated
buffer: Py_buffer
offset: Py_ssize_t
/
*args: array

serhiy-storchaka Jan 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I prever to use more specific name values.

Comment thread Modules/_struct.c Outdated
/*[clinic input]
Struct.pack_into as s_pack_into

buffer: Py_buffer

serhiy-storchaka Jan 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The buffer must be writeable.

Comment thread Modules/_struct.c
offset. Note that the offset is a required argument. See\n\
help(struct) for more on format strings.");
/*[clinic input]
Struct.pack_into as s_pack_into

serhiy-storchaka Jan 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

No need to rename it.

skirpichev mentioned this pull request Jan 15, 2026
Merged
skirpichev closed this Jan 15, 2026
skirpichev deleted the struct-AC/143672 branch January 15, 2026 12:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka left review comments
sobolevn sobolevn left review comments

Assignees

No one assigned

Labels

awaiting review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL