FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-143421: Use new buffer to save optimized uops by cocolato · Pull Request #143682 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-143421: Use new buffer to save optimized uops - #143682

Merged
Fidget-Spinner merged 12 commits into
python:mainfrom
cocolato:feat/ADD_OP
Jan 17, 2026
ConversationCommits (12)ChecksFiles changed
Merged

gh-143421: Use new buffer to save optimized uops#143682
Fidget-Spinner merged 12 commits into
python:mainfrom
cocolato:feat/ADD_OP

Conversation

cocolato commented Jan 11, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

python-cla-bot Bot commented Jan 11, 2026 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

bedevere-app Bot mentioned this pull request Jan 11, 2026
Closed

cocolato commented Jan 11, 2026

Copy link
Copy Markdown
Member Author

@Fidget-Spinner There may be many details that need fixing, and I hope you can give me some suggestions.

cocolato commented Jan 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

I haven't yet removed the cases of REPLACE_OP((inst+1),...), perhaps there's a better way to achieve this.

cpython/Python/optimizer_analysis.c

Line 244 in 03e6457

REPLACE_OP((this_instr+1), _EXIT_TRACE, 0, 0);

Fidget-Spinner reviewed Jan 11, 2026
View reviewed changes

Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks, this is really valuable work. We definitely need this.

Comment thread Python/optimizer_analysis.c Outdated
Comment thread Python/optimizer_analysis.c Outdated
Comment thread Include/internal/pycore_optimizer_types.h Outdated
Comment thread Python/optimizer_analysis.c Outdated
Comment thread Python/optimizer_bytecodes.c
Comment thread Python/optimizer_analysis.c

cocolato commented Jan 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Thanks for taking the time to review this! I will rewrite them later.

Fidget-Spinner reviewed Jan 12, 2026
View reviewed changes

Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Quite close.

Comment thread Include/internal/pycore_tstate.h Outdated
Comment thread Include/internal/pycore_optimizer_types.h Outdated

cocolato commented Jan 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Updated, thanks for your patient guidance!

Fidget-Spinner reviewed Jan 12, 2026
View reviewed changes

Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ok, last few minor comments. then I think this is ready to merge.

Thank you for your patience in enduring my comments :).

Comment thread Python/optimizer_analysis.c Outdated
Comment thread Python/optimizer_analysis.c Outdated
Comment thread Python/optimizer_analysis.c Outdated

cocolato commented Jan 12, 2026

Copy link
Copy Markdown
Member Author

I may have misunderstood the previous comment. Thank you again for your guidance!

Fidget-Spinner commented Jan 12, 2026

Copy link
Copy Markdown
Member

Will leave this open for three days in case any other people want to review.

Fidget-Spinner merged commit b4b7324 into python:main Jan 17, 2026
72 checks passed

Fidget-Spinner commented Jan 17, 2026

Copy link
Copy Markdown
Member

Thanks!

cocolato deleted the feat/ADD_OP branch January 20, 2026 14:13
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
pythongh-143421: Use new buffer to save optimized uops (pythonGH-143682)
f8ace70
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

picnixz picnixz left review comments
markshannon Awaiting requested review from markshannon markshannon is a code owner
tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
savannahostrowski Awaiting requested review from savannahostrowski
Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL