Repository navigation
gh-131798: JIT optimizer: Support custom binary op and property frames - #143735
Merged
Fidget-Spinner merged 3 commits intoJan 13, 2026
Merged
Fidget-Spinner merged 3 commits into
Fidget-Spinner merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
savannahostrowski
self-requested a review
January 13, 2026 04:25
savannahostrowski
requested changes
Jan 13, 2026
Comment thread
Lib/test/test_capi/test_opt.py
Outdated
Comment thread
Python/optimizer_bytecodes.c
Comment thread
Lib/test/test_capi/test_opt.py
Outdated
Comment thread
Python/optimizer_bytecodes.c
Copy link
Copy Markdown
|
When you're done making the requested changes, leave the comment: I have made the requested changes; please review again. |
Sorry, something went wrong.
savannahostrowski
approved these changes
Jan 13, 2026
savannahostrowski
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
thunder-coding
pushed a commit
to thunder-coding/cpython
that referenced
this pull request
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BINARY_OP_SUBSCR_INIT_FRAME is the opcode for subscripting custom __getitem__.
LOAD_ATTR_PROPERTY is the opcode for loading an attribute decorated with @property.
I see a solid 0.5-1% speedup from this PR alone on Sam's fastmark (pyperformance subset).