gh-119180: Document the format parameter in typing.get_type_hints() - #143758
Merged
JelleZijlstra merged 5 commits intoApr 23, 2026
Merged
gh-119180: Document the format parameter in typing.get_type_hints()#143758JelleZijlstra merged 5 commits into
JelleZijlstra merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
30 tasks
Viicos
commented
Jan 12, 2026
Comment thread
Doc/library/typing.rst
Outdated
Do not mention `__annotations__` dictionaries, as this is slightly outdated since 3.14. Rewrite the note about possible exceptions for clarity. Also do not mention imported type aliases, as since 3.12 aliases with the `type` statement do not suffer from this limitation anymore.
Viicos
force-pushed
the
document-get-type-hints-format
branch
from
f0779d2 to
9dd2b19
Compare
January 12, 2026 21:12
Copy link
Copy Markdown
Member
Yes, would you mind changing that line to reference annotationlib.get_annotations instead? |
Sorry, something went wrong.
AlexWaygood
removed their request for review
January 13, 2026 11:23
Copy link
Copy Markdown
Member
|
@copilot resolve the merge conflicts in this pull request |
Sorry, something went wrong.
JelleZijlstra
approved these changes
Apr 23, 2026
Copy link
Copy Markdown
|
Thanks @Viicos for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-148901 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
JelleZijlstra
pushed a commit
that referenced
this pull request
Apr 23, 2026
…_hints()` (GH-143758) (#148901) Do not mention `__annotations__` dictionaries, as this is slightly outdated since 3.14. Rewrite the note about possible exceptions for clarity. Also do not mention imported type aliases, as since 3.12 aliases with the `type` statement do not suffer from this limitation anymore. (cherry picked from commit 8bf99ae) Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
…hints()` (python#143758) Do not mention `__annotations__` dictionaries, as this is slightly outdated since 3.14. Rewrite the note about possible exceptions for clarity. Also do not mention imported type aliases, as since 3.12 aliases with the `type` statement do not suffer from this limitation anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm wondering if we should also update this section:
cpython/Doc/library/typing.rst
Lines 3336 to 3337 in 66e1399
This gives some sense that accessing __annotations__ is safe, which is no longer the case.
📚 Documentation preview 📚: https://cpython-previews--143758.org.readthedocs.build/