FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-143460: Correct unlimited stack size skip for Emscripten by freakboy3742 · Pull Request #143765 · python/cpython · GitHub

/ cpython Public

gh-143460: Correct unlimited stack size skip for Emscripten #143765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
freakboy3742 merged 1 commit into from
Jan 13, 2026
Conversation 7 Commits 1 Checks 54 Files changed
Merged

gh-143460: Correct unlimited stack size skip for Emscripten #143765

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .py  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
2 changes: 1 addition & 1 deletion Lib/test/support/__init__.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -1781,7 +1781,7 @@ def skip_if_unlimited_stack_size(test):

See https://github.com/python/cpython/issues/143460.
"""
if is_wasi or os.name == "nt":
if is_emscripten or is_wasi or os.name == "nt":
return test

import resource

vstinner Jan 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Another option is to remove if is_wasi or os.name == "nt": and replace it with a more a generic:

Suggested change
import resource
try:
import resource
except ImportError:
return test

freakboy3742 Jan 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I thought about that approach, but I figured it would be better to be explicit about when resource is a required module so that you catch a case where resource fails to compile for some reason.
Expand Down
Loading
Back | FazBrowse Home | New Git URL