[3.14] gh-143880: Fix data race in functools.partial in free threading build - #143882
Merged
kumaraditya303 merged 1 commit intoJan 16, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…ng build The assignment to `pto->vectorcall` isn't thread-safe in the free threading build. Note that this is already fixed in the main branch.
mpage
approved these changes
Jan 15, 2026
kumaraditya303
approved these changes
Jan 16, 2026
Copy link
Copy Markdown
|
Thanks @colesbury for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 2, 2026
…threading build (pythonGH-143882) pythongh-143880: Fix data race in `functools.partial` in free threading build The assignment to `pto->vectorcall` isn't thread-safe in the free threading build. Note that this is already fixed in the main branch. (cherry picked from commit 0042384) Co-authored-by: Sam Gross <colesbury@gmail.com>
Copy link
Copy Markdown
|
GH-145435 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Saw this trigger a test failure in 3.13 TSan, so might as well backport it to 3.13 |
Sorry, something went wrong.
matthiasgoergens
added a commit
to matthiasgoergens/jax
that referenced
this pull request
Aug 8, 2026
race:partial_vectorcall_fallback (python/cpython#128050): the race was fixed on the 3.14 branch on 2026-01-16 (python/cpython#143882, follow-up issue python/cpython#143880), so the suppression is most likely dead. It is retained regardless: the hermetic TSAN CPython tarball the workflow downloads is an unversioned "3.14.x" artefact (declared to Bazel as 3.14.3), so nothing pins which source revision it was built from, and a wrongly removed suppression halts the nightly TSAN suite (halt_on_error=1) while a stale one costs nothing. The annotation records the two conditions under which it can go: provenance pinned to a post-fix revision, or a deliberately triggered green TSAN run without it. race:func_set_name (python/cpython#154821): fixed on the 3.14 branch on 2026-07-29 (python/cpython#154831); same removal condition once a rebuilt tarball contains the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The assignment to pto->vectorcall isn't thread-safe in the free threading build. Note that this is already fixed in the main branch.