Repository navigation
gh-142913: Remove JIT interpreter for interpreter generator tests - #143944
Merged
Fidget-Spinner merged 3 commits intoJan 17, 2026
Merged
Fidget-Spinner merged 3 commits into
Fidget-Spinner merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Fidget-Spinner
requested review from
DinoV and
mpage
and removed request for
DinoV
January 16, 2026 23:09
mpage
requested changes
Jan 16, 2026
mpage
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks like a few of the builds are failing because of the unused function.
Sorry, something went wrong.
Copy link
Copy Markdown
|
When you're done making the requested changes, leave the comment: I have made the requested changes; please review again. |
Sorry, something went wrong.
DinoV
approved these changes
Jan 17, 2026
DinoV
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
Comment thread
Modules/_testinternalcapi/interpreter.c
|
|
||
| int Test_EvalFrame_Resumes, Test_EvalFrame_Loads; | ||
|
|
||
| #ifdef _Py_TIER2 |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I think this should go into the new ceval.h to avoid duplication
Sorry, something went wrong.
This was referenced Feb 11, 2026
thunder-coding
pushed a commit
to thunder-coding/cpython
that referenced
this pull request
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the JIT builds to build again.