Repository navigation
gh-142913: fix _testinternalcapi build failure due to undefined JIT symbols - #143949
Closed
cocolato wants to merge 1 commit into
Closed
cocolato wants to merge 1 commit into
cocolato wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause:
The fix in 949b5ec removed the Tier 2 interpreter loop from Modules/_testinternalcapi/interpreter.c, but test_cases.c.h is generated from Python/bytecodes.c and still contains the TRACE_RECORD and TRACE_END instructions which call:
These functions are defined in Python/optimizer.c but are not exported (missing PyAPI_FUNC), causing link failures when building the shared library.