gh-143939: Fix assignment to _PyThreadStateImpl.generator_return_kind - #143951
Merged
colesbury merged 2 commits intoJan 20, 2026
Merged
gh-143939: Fix assignment to _PyThreadStateImpl.generator_return_kind#143951colesbury merged 2 commits into
colesbury merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…n_kind The assignment to generator_return_kind has to be after any potentially escaping calls or it might be overwritten.
johnslavik
reviewed
Jan 17, 2026
Comment thread
Lib/test/test_coroutines.py
Comment on lines
+2271
to
+2279
| class CallGeneratorOnDealloc: | ||
| def __del__(self): | ||
| def gen(): | ||
| yield 1 | ||
| next(gen()) | ||
|
|
||
| async def coro(): | ||
| obj = CallGeneratorOnDealloc() | ||
| return 42 |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
A little bit smaller in size:
Suggested change
| class CallGeneratorOnDealloc: | |
| def __del__(self): | |
| def gen(): | |
| yield 1 | |
| next(gen()) | |
| async def coro(): | |
| obj = CallGeneratorOnDealloc() | |
| return 42 | |
| class CallGeneratorOnDealloc: | |
| def __del__(self): | |
| next(x for x in [42]) | |
| async def coro(): | |
| obj = CallGeneratorOnDealloc() |
Sorry, something went wrong.
johnslavik
approved these changes
Jan 17, 2026
kumaraditya303
approved these changes
Jan 17, 2026
kumaraditya303
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
10 tasks
colesbury
enabled auto-merge (squash)
January 20, 2026 17:25
colesbury
disabled auto-merge
January 20, 2026 17:26
colesbury
enabled auto-merge (squash)
January 20, 2026 17:26
thunder-coding
pushed a commit
to thunder-coding/cpython
that referenced
this pull request
Feb 15, 2026
…rn_kind` (pythongh-143951) The assignment to generator_return_kind has to be after any potentially escaping calls to ensure that it's not overwritten.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The assignment to generator_return_kind must be after any potentially escaping calls to ensure that it's not overwritten.