FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-143952: Fix asyncio tools to work with the new remote debugging API by johnslavik · Pull Request #143954 · python/cpython · GitHub

Repository navigation

gh-143952: Fix asyncio tools to work with the new remote debugging API - #143954

Merged
pablogsal merged 4 commits into
python:mainfrom
johnslavik:fix-asyncio-tools-new-frameinfo-api
Jan 18, 2026
Merged

pablogsal merged 4 commits into
python:mainfrom
johnslavik:fix-asyncio-tools-new-frameinfo-api

Conversation

johnslavik commented Jan 17, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

aisk commented Jan 17, 2026

Copy link
Copy Markdown
Member

Hi, I'm wondering if we can add some tests to ensure we don't break this again in the future?

johnslavik marked this pull request as draft January 17, 2026 07:00

Copy link
Copy Markdown
Member Author

Something's very wrong here. On it.

johnslavik commented Jan 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Oh, okay. We have tests for tools but we don't import structures from _remote_debugging. Instead we have our own:

FrameInfo = namedtuple('FrameInfo', ['funcname', 'filename', 'lineno'])
CoroInfo = namedtuple('CoroInfo', ['call_stack', 'task_name'])
TaskInfo = namedtuple('TaskInfo', ['task_id', 'task_name', 'coroutine_stack', 'awaited_by'])
AwaitedInfo = namedtuple('AwaitedInfo', ['thread_id', 'awaited_by'])

CC @kumaraditya303

Copy link
Copy Markdown
Member Author

OK I guess that's it for the fix itself!

johnslavik marked this pull request as ready for review January 17, 2026 07:16

johnslavik commented Jan 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

We'd want to keep these structures in sync later (we also don't have .opcode in FrameInfo in tests for instance).
I'll check the remote debugging tests in regard to how they manage these structures.

Copy link
Copy Markdown
Member Author

OK, it's not a problem. We would just have to pass sequences and we could use original structures.

>>> from _remote_debugging import FrameInfo
>>> FrameInfo(range(4))
_remote_debugging.FrameInfo(filename=0, location=1, funcname=2, opcode=3)

Copy link
Copy Markdown
Member Author

We'd want to keep these structures in sync later (we also don't have .opcode in FrameInfo in tests for instance). I'll check the remote debugging tests in regard to how they manage these structures.

See GH-143955.

pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Great catch! In retrospective this indeed was doomed to happen so I am glad that we are looking at this

pablogsal merged commit 63cc125 into python:main Jan 18, 2026
51 checks passed
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
johnslavik deleted the fix-asyncio-tools-new-frameinfo-api branch April 20, 2026 23:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL