| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Hi, I'm wondering if we can add some tests to ensure we don't break this again in the future? |
Sorry, something went wrong.
|
Something's very wrong here. On it. |
Sorry, something went wrong.
|
Oh, okay. We have tests for tools but we don't import structures from _remote_debugging. Instead we have our own: cpython/Lib/test/test_asyncio/test_tools.py Lines 7 to 11 in 1b52ce8 |
Sorry, something went wrong.
|
OK I guess that's it for the fix itself! |
Sorry, something went wrong.
|
We'd want to keep these structures in sync later (we also don't have .opcode in FrameInfo in tests for instance). |
Sorry, something went wrong.
|
OK, it's not a problem. We would just have to pass sequences and we could use original structures. >>> from _remote_debugging import FrameInfo
>>> FrameInfo(range(4))
_remote_debugging.FrameInfo(filename=0, location=1, funcname=2, opcode=3) |
Sorry, something went wrong.
See GH-143955. |
Sorry, something went wrong.
There was a problem hiding this comment.
Great catch! In retrospective this indeed was doomed to happen so I am glad that we are looking at this
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.