FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-102809: No longer mention `Misc/gdbinit` in the code by johnslavik · Pull Request #143980 · python/cpython · GitHub

/ cpython Public

gh-102809: No longer mention Misc/gdbinit in the code - #143980

Merged
vstinner merged 1 commit into
python:mainfrom
johnslavik:farewell-gdbinit
Jan 19, 2026
ConversationCommits (1)ChecksFiles changed
Merged

gh-102809: No longer mention Misc/gdbinit in the code#143980
vstinner merged 1 commit into
python:mainfrom
johnslavik:farewell-gdbinit

Conversation

johnslavik commented Jan 18, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Misc/gdbinit was removed in GH-102854 (3.12.0a7).

johnslavik added skip news needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jan 18, 2026
johnslavik changed the title No longer mention Misc/gdbinit in PyObject_Dump code doc No longer mention Misc/gdbinit in the code Jan 18, 2026
StanFromIreland reviewed Jan 18, 2026
View reviewed changes

StanFromIreland left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Or fix it like this one was done?

cpython/Doc/howto/gdb_helpers.rst

Line 40 in 63cc125

- GDB 7 or later. (For earlier versions of GDB, see ``Misc/gdbinit`` in the

johnslavik commented Jan 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Or fix it like this one was done?

cpython/Doc/howto/gdb_helpers.rst

Line 40 in 63cc125

- GDB 7 or later. (For earlier versions of GDB, see ``Misc/gdbinit`` in the

I'm not sure. This comment remains on 3.10, 3.11 and 3.12 branches, would including Misc/gdbinit again be helpful?
Or do you mean mentioning GDB 7?
Or do you have in mind some other specific idea of improving this comment?

We could direct the reader to Doc/howto/gdb_helpers.rst maybe?

StanFromIreland commented Jan 18, 2026

Copy link
Copy Markdown
Member

Oh I only have the one line shown, I was referring to: "see Misc/gdbinit in the sources of Python 3.11 or earlier."

johnslavik commented Jan 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Thanks. Personally, I don't find it necessary, because the 3.11 and earlier branches still will include the mention of Misc/gdbinit after we merge this.

StanFromIreland commented Jan 18, 2026

Copy link
Copy Markdown
Member

Why do those branches matter? The comment is for people on the branches where the file doesn't exist, no?

johnslavik commented Jan 18, 2026

Copy link
Copy Markdown
Member Author

Why do those branches matter? The comment is for people on the branches where the file doesn't exist, no?

I was thinking that mentioning Misc/gdbinit would not be useful to people on branches that don't contain the file, because they wouldn't need nor be able to use the file.

If they needed to debug 3.11, they would check it out and the comment would be there.
Unless I am missing something?

johnslavik commented Jan 18, 2026

Copy link
Copy Markdown
Member Author

Do you have an example of when this is useful for someone debugging in the 3.13-3.15 branches only?

ZeroIntensity commented Jan 18, 2026

Copy link
Copy Markdown
Member

Yeah, I agree with Bartosz here. The mention in the docs was added after Misc/gdbinit was removed, so I think it's intentional to keep that one.

vstinner approved these changes Jan 19, 2026
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

vstinner changed the title No longer mention Misc/gdbinit in the code gh-102809: No longer mention Misc/gdbinit in the code Jan 19, 2026
bedevere-app Bot mentioned this pull request Jan 19, 2026
Closed
vstinner merged commit f84ea11 into python:main Jan 19, 2026
61 checks passed

miss-islington-app Bot commented Jan 19, 2026

Copy link
Copy Markdown

Thanks @johnslavik for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 19, 2026
pythongh-102809: No longer mention Misc/gdbinit in the code (python…
8340f58 
…GH-143980)

Fix misleading comment on `PyObject_Dump`.
(cherry picked from commit f84ea11)

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 19, 2026
pythongh-102809: No longer mention Misc/gdbinit in the code (python…
34881e4 
…GH-143980)

Fix misleading comment on `PyObject_Dump`.
(cherry picked from commit f84ea11)

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>

bedevere-app Bot commented Jan 19, 2026

Copy link
Copy Markdown

GH-144044 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jan 19, 2026

bedevere-app Bot commented Jan 19, 2026

Copy link
Copy Markdown

GH-144045 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jan 19, 2026

vstinner commented Jan 19, 2026

Copy link
Copy Markdown
Member

Merged, thanks for this cleanup.

johnslavik commented Jan 19, 2026

Copy link
Copy Markdown
Member Author

@vstinner, thanks for the review and for linking the issue!

vstinner pushed a commit that referenced this pull request Jan 19, 2026
[3.13] gh-102809: No longer mention Misc/gdbinit in the code (GH-14…
7bca3dd 
…3980) (#144045)

gh-102809: No longer mention `Misc/gdbinit` in the code (GH-143980)

Fix misleading comment on `PyObject_Dump`.
(cherry picked from commit f84ea11)

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
vstinner pushed a commit that referenced this pull request Jan 19, 2026
[3.14] gh-102809: No longer mention Misc/gdbinit in the code (GH-14…
27256ca 
…3980) (#144044)

gh-102809: No longer mention `Misc/gdbinit` in the code (GH-143980)

Fix misleading comment on `PyObject_Dump`.
(cherry picked from commit f84ea11)

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
pythongh-102809: No longer mention Misc/gdbinit in the code (python…
746eb98 
…#143980)

Fix misleading comment on `PyObject_Dump`.
johnslavik deleted the farewell-gdbinit branch April 20, 2026 23:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

StanFromIreland StanFromIreland left review comments
vstinner vstinner approved these changes
ZeroIntensity ZeroIntensity approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL