FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-143959: Make _datetime optional for test_sys by youknowone · Pull Request #144003 · python/cpython · GitHub

/ cpython Public

gh-143959: Make _datetime optional for test_sys - #144003

Merged
serhiy-storchaka merged 3 commits into
python:mainfrom
youknowone:test_sys-_datetime
Jan 22, 2026
ConversationCommits (3)ChecksFiles changed
Merged

gh-143959: Make _datetime optional for test_sys#144003
serhiy-storchaka merged 3 commits into
python:mainfrom
youknowone:test_sys-_datetime

Conversation

youknowone commented Jan 18, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

The _datetime dependency of test_sys is only required for @cpython_only decorated test.

bedevere-app Bot added the tests Tests in the Lib/test dir label Jan 18, 2026
bedevere-app Bot mentioned this pull request Jan 18, 2026
Open
vstinner approved these changes Jan 19, 2026
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

serhiy-storchaka reviewed Jan 20, 2026
View reviewed changes
Comment thread Lib/test/test_sys.py Outdated
self.assertEqual(sys.getsizeof(True, -1), size('') + self.longdigit)

def test_objecttypes(self):
import _datetime

serhiy-storchaka Jan 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I suggest to import it just before it is used, like collections.

And since it is optional, skip the corresponding test if the import fails.

youknowone Jan 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks! Fixed it

vstinner Jan 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

And since it is optional, skip the corresponding test if the import fails.

_datetime is now a built-in module, it's not really optional.

serhiy-storchaka Jan 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Isn't it just an implementation detail? It was made builtin to solve a particular technical issue which can be solved in other way.

serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jan 20, 2026
vstinner reviewed Jan 21, 2026
View reviewed changes
Comment thread Lib/test/test_sys.py Outdated
check(x, size('5Pi'))
# PyCapsule
import _datetime
check(_datetime.datetime_CAPI, size('6P'))

vstinner Jan 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

As @serhiy-storchaka requested, this line should only be run if _datetime is available. Something like:

try:
    import _datetime
except ImportError:
    pass
else:
    check(_datetime.datetime_CAPI, size('6P'))

youknowone Jan 22, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

vstinner approved these changes Jan 22, 2026
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

serhiy-storchaka merged commit c447d1b into python:main Jan 22, 2026
45 checks passed

miss-islington-app Bot commented Jan 22, 2026

Copy link
Copy Markdown

Thanks @youknowone for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 22, 2026
pythongh-143959: Make _datetime optional for test_sys (pythonGH-144003)
e67612e 
(cherry picked from commit c447d1b)

Co-authored-by: Jeong, YunWon <69878+youknowone@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 22, 2026
pythongh-143959: Make _datetime optional for test_sys (pythonGH-144003)
97bef04 
(cherry picked from commit c447d1b)

Co-authored-by: Jeong, YunWon <69878+youknowone@users.noreply.github.com>

bedevere-app Bot commented Jan 22, 2026

Copy link
Copy Markdown

GH-144143 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jan 22, 2026

bedevere-app Bot commented Jan 22, 2026

Copy link
Copy Markdown

GH-144144 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jan 22, 2026
vstinner pushed a commit that referenced this pull request Jan 22, 2026
[3.13] gh-143959: Make _datetime optional for test_sys (GH-144003) (#…
015b90d 
…144144)

gh-143959: Make _datetime optional for test_sys (GH-144003)
(cherry picked from commit c447d1b)

Co-authored-by: Jeong, YunWon <69878+youknowone@users.noreply.github.com>
vstinner pushed a commit that referenced this pull request Jan 22, 2026
[3.14] gh-143959: Make _datetime optional for test_sys (GH-144003) (#…
6ec9485 
…144143)

gh-143959: Make _datetime optional for test_sys (GH-144003)
(cherry picked from commit c447d1b)

Co-authored-by: Jeong, YunWon <69878+youknowone@users.noreply.github.com>
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
pythongh-143959: Make _datetime optional for test_sys (pythonGH-144003)
8efd009
vstinner changed the title gh-143959 make test_sys import _datetime inside the test gh-143959: Make _datetime optional for test_sys Feb 19, 2026
youknowone mentioned this pull request Feb 21, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL