FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-144050: Fix stat.filemode pure Python file type detection by VanshAgarwal24036 · Pull Request #144059 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-144050: Fix stat.filemode pure Python file type detection - #144059

Merged
serhiy-storchaka merged 4 commits into
python:mainfrom
VanshAgarwal24036:gh-144050
Jan 20, 2026
ConversationCommits (4)ChecksFiles changed
Merged

gh-144050: Fix stat.filemode pure Python file type detection#144059
serhiy-storchaka merged 4 commits into
python:mainfrom
VanshAgarwal24036:gh-144050

Conversation

VanshAgarwal24036 commented Jan 20, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

This PR fixes a discrepancy between the C and pure Python implementations
of stat.filemode.

The pure Python implementation could misclassify arbitrary bit patterns
(e.g. 32767) as block devices. File type detection now correctly uses
(mode & S_IFMT) for file types, matching the C implementation.

A regression test is added to prevent this issue from recurring.

Fixes #144050

bedevere-app Bot mentioned this pull request Jan 20, 2026
Closed
serhiy-storchaka reviewed Jan 20, 2026
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please add a NEWS entry.

Comment thread Lib/test/test_stat.py Outdated
Comment thread Lib/stat.py
Update Misc/NEWS.d/next/Library/2026-01-20-16-35-55.gh-issue-144050.0…
b560d6e 
…kKFbF.rst

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka approved these changes Jan 20, 2026
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. 👍

serhiy-storchaka merged commit fe62926 into python:main Jan 20, 2026
51 checks passed
VanshAgarwal24036 deleted the gh-144050 branch January 20, 2026 12:11
serhiy-storchaka added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Jan 20, 2026

miss-islington-app Bot commented Jan 20, 2026

Copy link
Copy Markdown

Thanks @VanshAgarwal24036 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington-app Bot commented Jan 20, 2026

Copy link
Copy Markdown

Thanks @VanshAgarwal24036 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2026
pythongh-144050: Fix stat.filemode pure Python file type detection (p…
a89239a 
…ythonGH-144059)

(cherry picked from commit fe62926)

Co-authored-by: VanshAgarwal24036 <148854295+VanshAgarwal24036@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2026
pythongh-144050: Fix stat.filemode pure Python file type detection (p…
bed7f52 
…ythonGH-144059)

(cherry picked from commit fe62926)

Co-authored-by: VanshAgarwal24036 <148854295+VanshAgarwal24036@users.noreply.github.com>

bedevere-app Bot commented Jan 20, 2026

Copy link
Copy Markdown

GH-144073 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jan 20, 2026

bedevere-app Bot commented Jan 20, 2026

Copy link
Copy Markdown

GH-144074 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jan 20, 2026
serhiy-storchaka pushed a commit that referenced this pull request Jan 20, 2026
[3.13] gh-144050: Fix stat.filemode pure Python file type detection (G…
77dddec 
…H-144059) (GH-144074)

(cherry picked from commit fe62926)

Co-authored-by: VanshAgarwal24036 <148854295+VanshAgarwal24036@users.noreply.github.com>
serhiy-storchaka pushed a commit that referenced this pull request Jan 20, 2026
[3.14] gh-144050: Fix stat.filemode pure Python file type detection (G…
56cf72d 
…H-144059) (GH-144073)

(cherry picked from commit fe62926)

Co-authored-by: VanshAgarwal24036 <148854295+VanshAgarwal24036@users.noreply.github.com>
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
pythongh-144050: Fix stat.filemode pure Python file type detection (p…
d190965 
…ythonGH-144059)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Discrepancy between stat.filemode's C and Python implementation

2 participants

Back | FazBrowse Home | New Git URL