FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-144125: email: verify headers are sound in BytesGenerator by sethmlarson · Pull Request #144126 · python/cpython · GitHub

/ cpython Public

gh-144125: email: verify headers are sound in BytesGenerator - #144126

Merged
sethmlarson merged 3 commits into
python:mainfrom
sethmlarson:email-verify-headers-in-bytesgenerator
Jan 23, 2026
ConversationCommits (3)ChecksFiles changed
Merged

gh-144125: email: verify headers are sound in BytesGenerator#144126
sethmlarson merged 3 commits into
python:mainfrom
sethmlarson:email-verify-headers-in-bytesgenerator

Conversation

sethmlarson commented Jan 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

GH-122233 added an implementation to Generator to refuse to serialize (write) headers that are unsafely folded or delimited.

This revision adds the same implementation to BytesGenerator, so it gets the same safety protections for unsafely folded or delimited headers

sethmlarson requested a review from a team as a code owner January 21, 2026 19:15
sethmlarson added type-security A security issue stdlib Standard Library Python modules in the Lib/ directory topic-email labels Jan 21, 2026
bedevere-app Bot mentioned this pull request Jan 21, 2026
Closed
sethmlarson requested a review from bitdancer January 21, 2026 19:16
pythongh-144125: email: verify headers are sound in BytesGenerator
1132e45 
pythonGH-122233 added an implementation to `Generator`
to refuse to serialize (write) headers that
are unsafely folded or delimited.

This revision adds the same implementation
to `BytesGenerator`, so it gets the same safety protections
for unsafely folded or delimited headers

Co-authored-by: Denis Ledoux <5822488+beledouxdenis@users.noreply.github.com>
Co-authored-by: Petr Viktorin <302922+encukou@users.noreply.github.com>
Co-authored-by: Bas Bloemsaat <1586868+basbloemsaat@users.noreply.github.com>
sethmlarson force-pushed the email-verify-headers-in-bytesgenerator branch from cd41a69 to 1132e45 Compare January 21, 2026 19:17
bitdancer requested changes Jan 21, 2026
View reviewed changes
Comment thread Lib/test/test_email/test_generator.py
Comment thread Lib/test/test_email/test_policy.py

bedevere-app Bot commented Jan 21, 2026

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

sethmlarson commented Jan 22, 2026

Copy link
Copy Markdown
Contributor Author

@bitdancer I have made the requested changes; please review again

bedevere-app Bot commented Jan 22, 2026

Copy link
Copy Markdown

Thanks for making the requested changes!

@bitdancer: please review the changes made to this pull request.

bedevere-app Bot requested a review from bitdancer January 22, 2026 15:18
sethmlarson merged commit 052e55e into python:main Jan 23, 2026
92 of 100 checks passed
sethmlarson deleted the email-verify-headers-in-bytesgenerator branch January 23, 2026 14:59
sethmlarson added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jan 23, 2026
sethmlarson added the needs backport to 3.14 bugs and security fixes label Jan 23, 2026

miss-islington-app Bot commented Jan 23, 2026

Copy link
Copy Markdown

Thanks @sethmlarson for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington-app Bot commented Jan 23, 2026

Copy link
Copy Markdown

Thanks @sethmlarson for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app Bot commented Jan 23, 2026

Copy link
Copy Markdown

Thanks @sethmlarson for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

sethmlarson added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes and removed needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jan 23, 2026

miss-islington-app Bot commented Jan 23, 2026

Copy link
Copy Markdown

Thanks @sethmlarson for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington-app Bot commented Jan 23, 2026

Copy link
Copy Markdown

Thanks @sethmlarson for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

hugovk removed needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jan 26, 2026
This was referenced Mar 13, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bitdancer bitdancer approved these changes

Assignees

No one assigned

Labels

stdlib Standard Library Python modules in the Lib/ directory topic-email type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL