Repository navigation
gh-130415: Narrow types to constants in branches involving specialized comparisons with a constant - #144150
Merged
Fidget-Spinner merged 9 commits intoJan 24, 2026
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
reidenong
requested review from
Fidget-Spinner,
markshannon,
savannahostrowski and
tomasr8
as code owners
January 22, 2026 13:30
13 of 17 tasks
Copy link
Copy Markdown
Contributor
Author
|
After discussion with Ken Jin I will be adding implementations for all _COMPARE_OP_* in this PR |
Sorry, something went wrong.
Fidget-Spinner
approved these changes
Jan 24, 2026
Fidget-Spinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks
Sorry, something went wrong.
thunder-coding
pushed a commit
to thunder-coding/cpython
that referenced
this pull request
Feb 15, 2026
…ialized comparisons with a constant (pythonGH-144150)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the new predicate optimizer symbol to narrow types to constants in branches involving comparisons with a constant.
This PR provides the implementation for _COMPARE_OP_INT , _COMPARE_OP_STR, _COMPARE_OP_FLOAT.