FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-74902: Avoid hitting unicode.org for test data by zware · Pull Request #144195 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-74902: Avoid hitting unicode.org for test data - #144195

Merged
zware merged 1 commit into
python:mainfrom
zware:unicode_test_fixup
Jan 23, 2026
ConversationCommits (1)ChecksFiles changed
Merged

gh-74902: Avoid hitting unicode.org for test data#144195
zware merged 1 commit into
python:mainfrom
zware:unicode_test_fixup

Conversation

zware commented Jan 23, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Use our own pythontest.net instead.

zware added tests Tests in the Lib/test dir skip news topic-unicode labels Jan 23, 2026
bedevere-app Bot mentioned this pull request Jan 23, 2026
Closed

zware commented Jan 23, 2026

Copy link
Copy Markdown
Member Author

unicode.org returned 403s to a couple of my buildbot workers; using pythontest.net instead ensures that we're not taxing their server and puts the source of our test data in our control.

Test data added to pythontest.net in python/pythontestdotnet@a66b3bb

serhiy-storchaka approved these changes Jan 23, 2026
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. 👍

Comment thread Lib/test/test_unicodedata.py
f"into the test data directory")
except (OSError, HTTPException) as exc:
self.skipTest(f"Failed to download {TESTDATAURL}: {exc}")
TESTDATAFILE = "GraphemeBreakTest.txt"

serhiy-storchaka Jan 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

So, it is not in auxiliary?

zware Jan 23, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It is not; since we only have three files in there (up from two before adding this one), the extra directory seemed unnecessary. Easy enough to add back if you want it, though.

zware merged commit 58ccf21 into python:main Jan 23, 2026
57 checks passed
zware deleted the unicode_test_fixup branch January 23, 2026 21:07
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
pythongh-74902: Avoid hitting unicode.org for test data (pythonGH-144195
fc836b8 
)

Use our own pythontest.net instead.
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Apr 8, 2026
pythongh-74902: Avoid hitting unicode.org for test data (pythonGH-144195
9efe825 
)

Use our own pythontest.net instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir topic-unicode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL