gh-141004: Document remaining pyport.h utility macros - #144279
Conversation
Sorry, something went wrong.
| *type* is the type of the expression. In modern versions of Python, this is | ||
| unused. Historically, *type* was used to cast *integer*. |
There was a problem hiding this comment.
Can we reformulate this more precisely through a versionchanged? And indicate that the parameter is unused and kept for backward compatibility?
Sorry, something went wrong.
There was a problem hiding this comment.
There's already a versionchanged that specifies this below.
Sorry, something went wrong.
There was a problem hiding this comment.
Oh sorry. In this case, I think we can just say that it's not used anymore and only kept for BC. The change has been done in 3.1 so whatever is after 3.1 is already "modern" Python.
Sorry, something went wrong.
There was a problem hiding this comment.
Done.
Sorry, something went wrong.
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
|
||
| *value*, *larger*, and *smaller* may all be evaluated more than once in the | ||
| expression; consequently, do not pass an expensive operation directly to | ||
| this macro. |
There was a problem hiding this comment.
Expressions with side effects (ex: value++) should also be avoided.
Sorry, something went wrong.
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
left a comment
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
|
Thanks @ZeroIntensity for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
Sorry, something went wrong.
…GH-144279) (cherry picked from commit 914fbec) Co-authored-by: Peter Bierma <zintensitydev@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Victor Stinner <vstinner@python.org>
|
GH-144477 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
|
GH-144478 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
…GH-144279) (cherry picked from commit 914fbec) Co-authored-by: Peter Bierma <zintensitydev@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Victor Stinner <vstinner@python.org>
…4279) (GH-144477) gh-141004: Document remaining `pyport.h` utility macros (GH-144279) (cherry picked from commit 914fbec) Co-authored-by: Peter Bierma <zintensitydev@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Victor Stinner <vstinner@python.org>
…4279) (GH-144478) gh-141004: Document remaining `pyport.h` utility macros (GH-144279) (cherry picked from commit 914fbec) Co-authored-by: Peter Bierma <zintensitydev@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Victor Stinner <vstinner@python.org>
…GH-144279) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Victor Stinner <vstinner@python.org>
…GH-144279) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Victor Stinner <vstinner@python.org>
…GH-144279) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Victor Stinner <vstinner@python.org>
📚 Documentation preview 📚: https://cpython-previews--144279.org.readthedocs.build/en/144279/c-api/intro.html#useful-macros