GH-144179: Add value recording to JIT tracing front-end - #144303
Conversation
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 515a570 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F144303%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
Sorry, something went wrong.
Fidget-Spinner
left a comment
There was a problem hiding this comment.
Just one nit, feel free to merge after.
Sorry, something went wrong.
| @@ -0,0 +1,115 @@ | |||
| // This file is generated by Tools/cases_generator/record_function_generator.py | |||
There was a problem hiding this comment.
Should this file be mark as autogenerated in the github CI?
Sorry, something went wrong.
| assert(strncmp(_PyOpcode_uop_name[buffer[pc].opcode], _PyOpcode_uop_name[opcode], strlen(_PyOpcode_uop_name[opcode])) == 0); | ||
| } | ||
| else if (_PyUop_Flags[opcode] & HAS_RECORDS_VALUE_FLAG) { | ||
| Py_XDECREF((PyObject *)(uintptr_t)buffer[pc].operand0); |
There was a problem hiding this comment.
We should move this to the finalize tracing path. Otherwise, this doesn't handle the error paths
Sorry, something went wrong.
First step toward cleaning up front-end tracking of objects.
This adds recording, but doesn't use for optimization, to keep the PRs to manageable sizes.
Demonstrates that it works, doesn't leak memory.
Also removes IP_OFFSET_OF, as that broke when adding new uops.