FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-139109: Replace `_CHECK_STACK_SPACE` with `_CHECK_STACK_SPACE_OPERAND` in JIT optiimizer by cocolato · Pull Request #144394 · python/cpython · GitHub

/ cpython Public

gh-139109: Replace _CHECK_STACK_SPACE with _CHECK_STACK_SPACE_OPERAND in JIT optiimizer - #144394

Merged
markshannon merged 3 commits into
python:mainfrom
cocolato:optimize/CHECK_STACK_SPACE
Feb 2, 2026
ConversationCommits (3)ChecksFiles changed
Merged

gh-139109: Replace _CHECK_STACK_SPACE with _CHECK_STACK_SPACE_OPERAND in JIT optiimizer#144394
markshannon merged 3 commits into
python:mainfrom
cocolato:optimize/CHECK_STACK_SPACE

Conversation

cocolato commented Feb 2, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Refer: #144388
This implements a simple one-to-one replacement of _CHECK_STACK_SPACE with _CHECK_STACK_SPACE_OPERAND in the JIT optimizer.
Also open and rewrite all the tests that are disabled in #139109.

bedevere-app Bot mentioned this pull request Feb 2, 2026
Open
cocolato commented Feb 2, 2026
View reviewed changes
Comment thread Lib/test/test_capi/test_opt.py
markshannon requested changes Feb 2, 2026
View reviewed changes

markshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good generally.
I suspect that using ADD_OP and REPLACE_OP together may be broken, but that won't matter if we make _CHECK_STACK_SPACE_OPERAND only check stack space.

Comment thread Lib/test/test_capi/test_opt.py
Comment thread Python/optimizer_bytecodes.c Outdated
Comment thread Python/optimizer_bytecodes.c Outdated

bedevere-app Bot commented Feb 2, 2026

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

cocolato commented Feb 2, 2026

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

bedevere-app Bot commented Feb 2, 2026

Copy link
Copy Markdown

Thanks for making the requested changes!

@markshannon: please review the changes made to this pull request.

bedevere-app Bot requested a review from markshannon February 2, 2026 16:23
markshannon approved these changes Feb 2, 2026
View reviewed changes

markshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This looks good now, thanks.

markshannon merged commit 89e6607 into python:main Feb 2, 2026
74 of 77 checks passed
Aniketsy pushed a commit to Aniketsy/cpython that referenced this pull request Feb 3, 2026
pythongh-139109: Replace _CHECK_STACK_SPACE with `_CHECK_STACK_SPAC…
9c07998 
…E_OPERAND` in JIT optiimizer (pythonGH-144394)
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
pythongh-139109: Replace _CHECK_STACK_SPACE with `_CHECK_STACK_SPAC…
9d90bcc 
…E_OPERAND` in JIT optiimizer (pythonGH-144394)
cocolato deleted the optimize/CHECK_STACK_SPACE branch March 17, 2026 08:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

markshannon markshannon approved these changes
tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner
Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner
savannahostrowski Awaiting requested review from savannahostrowski savannahostrowski is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL