| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
Overall, looks good to me. I left a comment about the test above.
Would you please also add a news entry?
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM as well
Sorry, something went wrong.
|
Thanks @eendebakpt for the PR, and @colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, something went wrong.
|
Sorry, @eendebakpt and @colesbury, I could not cleanly backport this to 3.14 due to a conflict. cherry_picker 009c8c052f5eb9f869c09029724ef194d8c161ca 3.14 |
Sorry, something went wrong.
|
Hmmm... are we backporting these sorts of PRs to 3.14 or no? It looks like some of the other ones are 3.15 only. |
Sorry, something went wrong.
…ns` and `itertools.combinations_with_replacement` thread-safe (pythongh-144402)
…ns` and `itertools.combinations_with_replacement` thread-safe (pythongh-144402)
…ns` and `itertools.combinations_with_replacement` thread-safe (pythongh-144402)
Can we remove the backport label? |
Sorry, something went wrong.
|
Please don't forget about backports. |
Sorry, something went wrong.
…132814) (GH-135689) (GH-144402) (GH-146033) (GH-142957) (GH-153791) Combined backport of PRs from main branch, fixing free-threading data-races in itertools: * gh-123471: make concurrent iteration over `itertools.cycle` safe under free-threading (gh-131212) * gh-123471: Make itertools.product and itertools.combinations thread-safe (GH-132814) * gh-123471: Make itertools.chain thread-safe (gh-135689) * gh-123471: Make concurrent iteration over `itertools.permutations` and `itertools.combinations_with_replacement` thread-safe (gh-144402) * gh-123471: make concurrent iteration over itertools.accumulate thread-safe (gh-144486) * gh-123471: Make `itertools.zip_longest` safe in the FT build (gh-146033) (cherry picked from commit 26a1cd4) (cherry picked from commit 847d1c2) (cherry picked from commit 0533c1f) (cherry picked from commit 009c8c0) (cherry picked from commit 3a24856) (cherry picked from commit 9214e3f) Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com> Co-authored-by: Kumar Aditya <kumaraditya@python.org>
| Back | FazBrowse Home | New Git URL |
We use a critical section similar to the approach in #132814.