FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-123471: Make concurrent iteration over itertools.permutations and itertools.combinations_with_replacement thread-safe by eendebakpt · Pull Request #144402 · python/cpython · GitHub

/ cpython Public

gh-123471: Make concurrent iteration over itertools.permutations and itertools.combinations_with_replacement thread-safe - #144402

Merged
colesbury merged 8 commits into
python:mainfrom
eendebakpt:cwr_ft
Feb 4, 2026
Merged

gh-123471: Make concurrent iteration over itertools.permutations and itertools.combinations_with_replacement thread-safe#144402
colesbury merged 8 commits into
python:mainfrom
eendebakpt:cwr_ft

Conversation

eendebakpt commented Feb 2, 2026
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

colesbury left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Overall, looks good to me. I left a comment about the test above.

Would you please also add a news entry?

kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

colesbury left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM as well

colesbury merged commit 009c8c0 into python:main Feb 4, 2026
51 checks passed

Copy link
Copy Markdown

Thanks @eendebakpt for the PR, and @colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

Copy link
Copy Markdown

Sorry, @eendebakpt and @colesbury, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 009c8c052f5eb9f869c09029724ef194d8c161ca 3.14

Copy link
Copy Markdown
Contributor

Hmmm... are we backporting these sorts of PRs to 3.14 or no? It looks like some of the other ones are 3.15 only.

encukou pushed a commit to encukou/cpython that referenced this pull request Feb 5, 2026
…ns` and `itertools.combinations_with_replacement` thread-safe (pythongh-144402)
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
…ns` and `itertools.combinations_with_replacement` thread-safe (pythongh-144402)
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
…ns` and `itertools.combinations_with_replacement` thread-safe (pythongh-144402)

Copy link
Copy Markdown
Member

Hmmm... are we backporting these sorts of PRs to 3.14 or no? It looks like some of the other ones are 3.15 only.

Can we remove the backport label?

Copy link
Copy Markdown
Member

Please don't forget about backports.

nascheme added a commit that referenced this pull request Jul 17, 2026
…132814) (GH-135689) (GH-144402) (GH-146033) (GH-142957) (GH-153791)

Combined backport of PRs from main branch, fixing free-threading data-races in itertools:

* gh-123471: make concurrent iteration over `itertools.cycle` safe under free-threading (gh-131212)
* gh-123471: Make itertools.product and itertools.combinations thread-safe (GH-132814)
* gh-123471: Make itertools.chain thread-safe (gh-135689)
* gh-123471: Make concurrent iteration over `itertools.permutations` and `itertools.combinations_with_replacement` thread-safe (gh-144402)
* gh-123471: make concurrent iteration over itertools.accumulate thread-safe (gh-144486)
* gh-123471: Make `itertools.zip_longest` safe in the FT build (gh-146033)

(cherry picked from commit 26a1cd4)
(cherry picked from commit 847d1c2)
(cherry picked from commit 0533c1f)
(cherry picked from commit 009c8c0)
(cherry picked from commit 3a24856)
(cherry picked from commit 9214e3f)

Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
StanFromIreland removed the needs backport to 3.14 bugs and security fixes label Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL