| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
(sorry for the pings) |
Sorry, something went wrong.
There was a problem hiding this comment.
Ok for ssl/hashlib
Sorry, something went wrong.
|
This is quite a churn. I don't think that it is so bad for module links, because the module documentation is usually much larger than a section, so the link usually leads beyond the screen. It is also possible to have documentation for several modules in the same file -- in that case links are useful, because they allow to find the start of the module documentation. When you read the documentation, its organization (several modules in one file or each module in a separate file) should not bother you -- links should work the same way. Even if you have a single module per file, clicking a link can be more convenient than scrolling to the beginning. |
Sorry, something went wrong.
My problem with links to the same page is that they fool you into thinking they will take you to a new place about the module, but they don't, you are back where you started. If I want to read the beginning of the page, I know what to do: I scroll to the top of the page. Links should help the reader. Linking to the same page isn't something readers need. |
Sorry, something went wrong.
|
I think that links at the beginning of the module documentation, in its preamble, should be avoided, but links in the documentation of its components should be kept. You may not even be aware that the link refers to the same page. You could read the documentation for foo(), then jumped to the documentation for bar() (in the baz module), which contains a link to the module, -- and at that moment you man not figure that it is the same module, because you did not start reading it from start. |
Sorry, something went wrong.
I think a self-link is even worse if the reader is unware that it's a self-link. That just adds to the disappointing surprise of being on the same page. These changes only remove links when they are to the module named in the first line of the file. You've mentioned two-module pages a few times: are there examples like that in this PR? I'd like to understand it better. |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM for argparse (but also overall, I think this is a solid update)!
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM for importlib.
Sorry, something went wrong.
|
Looks fine for email. I think this is a case of wanting the styling and not thinking about the fact that that means it creates a link by default. I think if it is consistent, which this PR seems to achieve, that the lack of a link becomes an indicator that you are on the same page as the module being named, which is probably more useful than the name always being a link and leaving you less clue that you stayed on the same page. It does need to be consistent, though, for that to be beneficial. |
Sorry, something went wrong.
|
LGTM for the logging pages. |
Sorry, something went wrong.
There was a problem hiding this comment.
zipapp, zipfile and zipimport lgtm!
Sorry, something went wrong.
|
GH-144542 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
I did not inspect eavery file, but some common multi-module pages are missed in this PR, so I think you already checked this. Although there may be cases when the module and its submodule are described in the same file. Well, I found one example -- json.tool and json. |
Sorry, something went wrong.
These are now fixed in the follow-up: #144695. |
Sorry, something went wrong.
* Docs: module pages should not link to themselves * fix header punctuation
* Docs: module pages should not link to themselves * fix header punctuation
| Back | FazBrowse Home | New Git URL |
The style guide says that sections should not link to themselves, since it is a pointless distraction. This updates module pages to remove links to themselves.
Done automatically with https://github.com/nedbat/odds/blob/master/rstwork/unlink-mod.py
Updated: relevant style guide section: https://devguide.python.org/documentation/style-guide/#links
📚 Documentation preview 📚: https://cpython-previews--144505.org.readthedocs.build/