FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-143700: document `secrets.DEFAULT_ENTROPY` as an opaque value by picnixz · Pull Request #144568 · python/cpython · GitHub

Repository navigation

gh-143700: document secrets.DEFAULT_ENTROPY as an opaque value - #144568

Merged
picnixz merged 4 commits into
python:mainfrom
picnixz:doc/secrets/document-default-entropy-143700
Feb 7, 2026
Merged

picnixz merged 4 commits into
python:mainfrom
picnixz:doc/secrets/document-default-entropy-143700

Conversation

picnixz commented Feb 7, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

picnixz commented Feb 7, 2026

Copy link
Copy Markdown
Member Author

I'm a bit unsure where to really put the name of that constant. I do want users to be able to use the constant itself but I don't want them to change it. Should I add an additional note saying that the value should not be changed?

gpshead left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm a bit unsure where to really put the name of that constant. I do want users to be able to use the constant itself but I don't want them to change it. Should I add an additional note saying that the value should not be changed?

that's probably overthinking it, we have all sorts of constants in Python modules that if changed will cause bad behavior - I don't think any special callout is necessary.

if we wanted to prevent it from being changed that'd require getting too creative with the module dict or using a C extension module instead. We rejected PEP-726 that could've offered an ability because the actual need was so rare.

Comment thread Doc/library/secrets.rst Outdated
Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
Comment thread Doc/library/secrets.rst Outdated
Comment thread Doc/library/secrets.rst Outdated
picnixz merged commit 9349972 into python:main Feb 7, 2026
33 checks passed
github-project-automation Bot moved this from Todo to Done in Docs PRs Feb 7, 2026

Copy link
Copy Markdown

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

picnixz deleted the doc/secrets/document-default-entropy-143700 branch February 7, 2026 22:36
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 7, 2026
pythonGH-144568)

(cherry picked from commit 9349972)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 7, 2026
pythonGH-144568)

(cherry picked from commit 9349972)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

bedevere-app Bot commented Feb 7, 2026

Copy link
Copy Markdown

GH-144579 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Feb 7, 2026

bedevere-app Bot commented Feb 7, 2026

Copy link
Copy Markdown

GH-144580 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Feb 7, 2026
picnixz added a commit that referenced this pull request Feb 7, 2026
…ue (GH-144568) (#144579)

gh-143700: document `secrets.DEFAULT_ENTROPY` as an opaque value (GH-144568)
(cherry picked from commit 9349972)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz added a commit that referenced this pull request Feb 7, 2026
…ue (GH-144568) (#144580)

gh-143700: document `secrets.DEFAULT_ENTROPY` as an opaque value (GH-144568)
(cherry picked from commit 9349972)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL