FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-131798: Optimize `_ITER_CHECK_RANGE` and `_ITER_CHECK_LIST` in the JIT by Sacul0457 · Pull Request #144583 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-131798: Optimize _ITER_CHECK_RANGE and _ITER_CHECK_LIST in the JIT #144583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 6 commits into from
Mar 17, 2026
Conversation 11 Commits 6 Checks 70 Files changed
Merged

gh-131798: Optimize _ITER_CHECK_RANGE and _ITER_CHECK_LIST in the JIT #144583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4449d84
optimise _ITER_CHECK_RANGE and _ITER_CHECK_LIST
Sacul0457 Feb 8, 2026
1490bd8
📜🤖 Added by blurb_it.
blurb-it[bot] Feb 8, 2026
bcc36ef
Add testcase for _ITER_CHECK_LIST
Sacul0457 Feb 18, 2026
ab8bd29
Merge branch 'main' into Optimize_ITER_CHECKs
Sacul0457 Feb 20, 2026
97d60b3
Merge branch 'main' into Optimize_ITER_CHECKs
Sacul0457 Mar 17, 2026
f5a4359
address review
Sacul0457 Mar 17, 2026
File filter

Filter by extension

Filter by extension .c  (1) .h  (1) .py  (1) .rst  (1) All 4 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
16 changes: 16 additions & 0 deletions Lib/test/test_capi/test_opt.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -3981,6 +3981,22 @@ def testfunc(n):
self.assertIn("_POP_TOP_NOP", uops)
self.assertLessEqual(count_ops(ex, "_POP_TOP"), 2)

def test_iter_check_list(self):
def testfunc(n):
x = 0
for _ in range(n):
l = [1]
for num in l: # unguarded
x += num
return x

res, ex = self._run_with_optimizer(testfunc, TIER2_THRESHOLD)
self.assertEqual(res, TIER2_THRESHOLD)
uops = get_opnames(ex)

self.assertIn("_BUILD_LIST", uops)
self.assertNotIn("_ITER_CHECK_LIST", uops)

def test_match_class(self):
def testfunc(n):
class A:
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2026-02-08-01-19-50.gh-issue-131798.PaWDNH.rst
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Optimize ``_ITER_CHECK_RANGE`` and ``_ITER_CHECK_LIST`` in the JIT
18 changes: 18 additions & 0 deletions Python/optimizer_bytecodes.c
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -1091,6 +1091,24 @@ dummy_func(void) {
sym_set_type(iter, &PyTuple_Type);
}

op(_ITER_CHECK_LIST, (iter, null_or_index -- iter, null_or_index)) {
if (sym_matches_type(iter, &PyList_Type)) {
ADD_OP(_NOP, 0, 0);
}
else {
sym_set_type(iter, &PyList_Type);
}
}

op(_ITER_CHECK_RANGE, (iter, null_or_index -- iter, null_or_index)) {
if (sym_matches_type(iter, &PyRange_Type)) {

Wulian233 Apr 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

cpython/Python/bytecodes.c

Line 3843 in 5c3deca

_PyRangeIterObject *r = (_PyRangeIterObject *)PyStackRef_AsPyObjectBorrow(iter);

@Sacul0457
It is _PyRangeIterObject. Why is it PyRange_Type here instead of PyRangeIter_Type?

Fidget-Spinner Apr 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oops, thanks for catching this. @Wulian233 could you please raise a PR to fix this?

Sacul0457 Apr 15, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good catch, thanks and sorry for the mistake!

Wulian233 Apr 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oops, thanks for catching this. @Wulian233 could you please raise a PR to fix this?

Sure! today
ADD_OP(_NOP, 0, 0);
}
else {
sym_set_type(iter, &PyRange_Type);
}
}

op(_ITER_NEXT_RANGE, (iter, null_or_index -- iter, null_or_index, next)) {
next = sym_new_type(ctx, &PyLong_Type);
}
Expand Down
16 changes: 16 additions & 0 deletions Python/optimizer_cases.c.h
Show comments
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Back | FazBrowse Home | New Git URL