FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.13] gh-131261: generate_sbom.py: Exclude the refresh script from SBOM (GH-131359) by encukou · Pull Request #144625 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

[3.13] gh-131261: generate_sbom.py: Exclude the refresh script from SBOM (GH-131359) - #144625

Merged
encukou merged 2 commits into
python:3.13from
encukou:backport-51d3099-3.13
Feb 10, 2026
ConversationCommits (2)ChecksFiles changed
Merged

[3.13] gh-131261: generate_sbom.py: Exclude the refresh script from SBOM (GH-131359)#144625
encukou merged 2 commits into
python:3.13from
encukou:backport-51d3099-3.13

Conversation

encukou commented Feb 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

(cherry picked from commit 51d3099)

encukou requested a review from sethmlarson as a code owner February 9, 2026 13:27
This was referenced Feb 9, 2026
Closed
Merged
encukou changed the title [3.13] gh-131261: expat/refresh.sh: Expand list of manual steps (GH-131359) [3.13] gh-131261: generate_sbom.py: Exclude the refresh script from SBOM (GH-131359) Feb 9, 2026

encukou commented Feb 9, 2026

Copy link
Copy Markdown
Member Author

This causes a conflict when backporting the expat update. In #144500, I currently bundle this fix with the expat update, but it seems cleaner to have it as a separate commit.

@sethmlarson, does that sound good?

sethmlarson approved these changes Feb 9, 2026
View reviewed changes

sethmlarson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thank you!

StanFromIreland reviewed Feb 9, 2026
View reviewed changes
Comment thread Modules/expat/refresh.sh
- Verify all is okay:
git diff
git status
- Regenerate the sbom file

StanFromIreland Feb 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Now that I look at it, this is missing a step, you have to update the version in the sbom file IIRC.

encukou Feb 10, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Could you send a PR for main?
I don't think it even needs to be backported since you only do that on main.

encukou merged commit bad4bc4 into python:3.13 Feb 10, 2026
53 checks passed
encukou deleted the backport-51d3099-3.13 branch February 10, 2026 09:49

miss-islington-app Bot commented Feb 10, 2026

Copy link
Copy Markdown

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington-app Bot commented Feb 10, 2026

Copy link
Copy Markdown

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington-app Bot commented Feb 10, 2026

Copy link
Copy Markdown

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington-app Bot commented Feb 10, 2026

Copy link
Copy Markdown

Sorry, @encukou, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker bad4bc4603fea4541b9e3db45b4050104e461c0a 3.10

miss-islington-app Bot commented Feb 10, 2026

Copy link
Copy Markdown

Sorry, @encukou, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker bad4bc4603fea4541b9e3db45b4050104e461c0a 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 10, 2026
[3.13] pythongh-131261: generate_sbom.py: Exclude the refresh script …
7b7483b 
…from SBOM (pythonGH-131359) (pythonGH-144625)

- generate_sbom.py: Exclude the refresh script from SBOM
- Modules/expat/refresh.sh: Expand the list of manual steps
(cherry picked from commit bad4bc4)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
(cherry picked from commit 51d3099)

bedevere-app Bot commented Feb 10, 2026

Copy link
Copy Markdown

GH-144660 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Feb 10, 2026
encukou mentioned this pull request Feb 10, 2026
Merged

StanFromIreland commented Feb 11, 2026

Copy link
Copy Markdown
Member

3.10/3.11 don't have the SBOM file.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

StanFromIreland StanFromIreland left review comments
sethmlarson sethmlarson approved these changes

Assignees

encukou

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL