gh-144490: Fix test_cppext on Windows - #144628
Merged
vstinner merged 1 commit intoFeb 9, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Don't include pycore_backoff.h and pycore_cell.h on Windows, since they emit C++ compiler warnings.
Copy link
Copy Markdown
Member
Author
|
On Windows with Python built in debug mode, TestInteralCAPI of test_cppext fails the following warnings: include\internal\mimalloc/mimalloc/types.h(509): error C2220: the following warning is treated as an error include\internal\mimalloc/mimalloc/types.h(509): warning C4324: 'mi_abandoned_pool_s': structure was padded due to alignment specifier include\internal\mimalloc/mimalloc/types.h(512): warning C4324: 'mi_abandoned_pool_s': structure was padded due to alignment specifier include\internal\mimalloc/mimalloc/types.h(513): warning C4324: 'mi_abandoned_pool_s': structure was padded due to alignment specifier include\internal\mimalloc/mimalloc/types.h(518): warning C4324: 'mi_abandoned_pool_s': structure was padded due to alignment specifier include\internal\pycore_qsbr.h(75): warning C4200: nonstandard extension used: zero-sized array in struct/union include\internal\pycore_qsbr.h(75): note: This member will be ignored by a defaulted constructor or copy/move assignment operator include\internal\pycore_uop.h(26): warning C4201: nonstandard extension used: nameless struct/union include\internal/pycore_backoff.h(66): error C7555: use of designated initializers requires at least '/std:c++20' include\internal/pycore_backoff.h(65): error C4576: a parenthesized type followed by an initializer list is a non-standard explicit type conversion syntax include\internal/pycore_backoff.h(84): error C7555: use of designated initializers requires at least '/std:c++20' include\internal/pycore_backoff.h(83): error C4576: a parenthesized type followed by an initializer list is a non-standard explicit type conversion syntax include\internal\pycore_tracemalloc.h(63): warning C4200: nonstandard extension used: zero-sized array in struct/union include\internal\pycore_tracemalloc.h(63): note: This member will be ignored by a defaulted constructor or copy/move assignment operator include\internal\pycore_stackref.h(372): error C7555: use of designated initializers requires at least '/std:c++20' include\internal\pycore_stackref.h(372): error C2737: 'PyStackRef_ERROR': const object must be initialized include\internal\pycore_stackref.h(376): error C7555: use of designated initializers requires at least '/std:c++20' include\internal\pycore_stackref.h(376): error C2737: 'PyStackRef_ZERO_BITS': const object must be initialized include\internal\pycore_stackref.h(390): error C7555: use of designated initializers requires at least '/std:c++20' include\internal\pycore_stackref.h(390): error C4576: a parenthesized type followed by an initializer list is a non-standard explicit type conversion syntax include\internal\pycore_stackref.h(435): error C7555: use of designated initializers requires at least '/std:c++20' include\internal\pycore_stackref.h(435): error C4576: a parenthesized type followed by an initializer list is a non-standard explicit type conversion syntax include\internal\pycore_stackref.h(452): error C7555: use of designated initializers requires at least '/std:c++20' include\internal\pycore_stackref.h(452): error C4576: a parenthesized type followed by an initializer list is a non-standard explicit type conversion syntax include\internal\pycore_stackref.h(466): error C7555: use of designated initializers requires at least '/std:c++20' include\internal\pycore_stackref.h(466): error C2737: 'PyStackRef_NULL': const object must be initialized include\internal\pycore_stackref.h(563): error C7555: use of designated initializers requires at least '/std:c++20' include\internal\pycore_stackref.h(563): error C4576: a parenthesized type followed by an initializer list is a non-standard explicit type conversion syntax include\internal\pycore_stackref.h(574): error C7555: use of designated initializers requires at least '/std:c++20' include\internal\pycore_stackref.h(574): error C4576: a parenthesized type followed by an initializer list is a non-standard explicit type conversion syntax include\internal\pycore_stackref.h(589): error C7555: use of designated initializers requires at least '/std:c++20' include\internal\pycore_stackref.h(589): error C4576: a parenthesized type followed by an initializer list is a non-standard explicit type conversion syntax include\internal\pycore_stackref.h(593): error C7555: use of designated initializers requires at least '/std:c++20' include\internal\pycore_stackref.h(593): error C4576: a parenthesized type followed by an initializer list is a non-standard explicit type conversion syntax include\internal\pycore_stackref.h(604): error C7555: use of designated initializers requires at least '/std:c++20' include\internal\pycore_stackref.h(604): error C4576: a parenthesized type followed by an initializer list is a non-standard explicit type conversion syntax include\internal\pycore_stackref.h(615): error C7555: use of designated initializers requires at least '/std:c++20' include\internal\pycore_stackref.h(615): error C4576: a parenthesized type followed by an initializer list is a non-standard explicit type conversion syntax error: command 'C:\\Program Files\\Microsoft Visual Studio\\2022\\Community\\VC\\Tools\\MSVC\\14.44.35207\\bin\\HostX86\\x64\\cl.exe' failed with exit code 2 error: subprocess-exited-with-error |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
!buildbot AMD64 Windows11 Non-Debug |
Sorry, something went wrong.
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @vstinner for commit 8c9afa5 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F144628%2Fmerge The command will test the builders whose names match following regular expression: AMD64 Windows11 Non-Debug The builders matched are:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
"AMD64 Windows11 Non-Debug PR" job is waiting for 2 hours for a Refleak job to complete. I will not wait longer for this job to run. Hugo asked for a fix for Tuesday to prepare Python releases. I tested my fix locally, so let me merge this fix. We will see later if my fix works on the buildbot. |
Sorry, something went wrong.
vstinner
added a commit
to vstinner/cpython
that referenced
this pull request
Feb 9, 2026
Don't include pycore_backoff.h and pycore_cell.h on Windows, since they emit C++ compiler warnings. (cherry picked from commit 245ba3d)
thunder-coding
pushed a commit
to thunder-coding/cpython
that referenced
this pull request
Feb 15, 2026
Don't include pycore_backoff.h and pycore_cell.h on Windows, since they emit C++ compiler warnings.
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
Don't include pycore_backoff.h and pycore_cell.h on Windows, since they emit C++ compiler warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't include pycore_backoff.h and pycore_cell.h on Windows, since they emit C++ compiler warnings.