FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-144629: Add test for the PyFunction_GetAnnotations function by nybblista · Pull Request #144630 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-144629: Add test for the PyFunction_GetAnnotations function - #144630

Merged
vstinner merged 1 commit into
python:mainfrom
nybblista:test-pyfunc-anno
Feb 10, 2026
ConversationCommits (1)ChecksFiles changed
Merged

gh-144629: Add test for the PyFunction_GetAnnotations function#144630
vstinner merged 1 commit into
python:mainfrom
nybblista:test-pyfunc-anno

Conversation

nybblista commented Feb 9, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Add test for the PyFunction_GetAnnotations function.

bedevere-app Bot mentioned this pull request Feb 9, 2026
Closed

nybblista commented Feb 9, 2026

Copy link
Copy Markdown
Contributor Author

@vstinner

vstinner reviewed Feb 9, 2026
View reviewed changes
Comment thread Lib/test/test_capi/test_function.py Outdated
Comment thread Modules/_testcapi/function.c Outdated
Comment thread Modules/_testcapi/function.c Outdated
nybblista requested a review from vstinner February 9, 2026 16:40

nybblista commented Feb 9, 2026

Copy link
Copy Markdown
Contributor Author

The other test functions in the function.c file use the same else style, so I kept it for consistency.

ZeroIntensity reviewed Feb 10, 2026
View reviewed changes
Comment thread Modules/_testcapi/function.c Outdated
ZeroIntensity added skip news needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes tests Tests in the Lib/test dir labels Feb 10, 2026

nybblista commented Feb 10, 2026

Copy link
Copy Markdown
Contributor Author

💯 I agree with @ZeroIntensity. However, I think it would be a good idea to apply the same approach to function_get_code, function_get_globals, and function_get_module.

vstinner commented Feb 10, 2026

Copy link
Copy Markdown
Member

However, I think it would be a good idea to apply the same approach to function_get_code, function_get_globals, and function_get_module.

I don't think that it's worth it to modify existing functions, it would only be a coding style change.

vstinner approved these changes Feb 10, 2026
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

vstinner enabled auto-merge (squash) February 10, 2026 14:11
vstinner merged commit cc81707 into python:main Feb 10, 2026
85 of 87 checks passed

miss-islington-app Bot commented Feb 10, 2026

Copy link
Copy Markdown

Thanks @nybblista for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 10, 2026
pythongh-144629: Add test for the PyFunction_GetAnnotations() function (
b75577b 
pythonGH-144630)

(cherry picked from commit cc81707)

Co-authored-by: Nybblista <170842536+nybblista@users.noreply.github.com>

miss-islington-app Bot commented Feb 10, 2026

Copy link
Copy Markdown

Sorry, @nybblista and @vstinner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker cc81707e406c49c63afc18048e1a221d796ce638 3.13

bedevere-app Bot commented Feb 10, 2026

Copy link
Copy Markdown

GH-144670 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Feb 10, 2026
vstinner removed the needs backport to 3.13 only security fixes label Feb 10, 2026

vstinner commented Feb 10, 2026

Copy link
Copy Markdown
Member

vstinner removed the needs backport to 3.13 label

3.13 branch lacks Modules/_testcapi/function.c file. I'm not interested to backport it.

vstinner commented Feb 10, 2026

Copy link
Copy Markdown
Member

Merged, thanks.

nybblista deleted the test-pyfunc-anno branch February 10, 2026 14:50
vstinner pushed a commit that referenced this pull request Feb 10, 2026
[3.14] gh-144629: Add test for the PyFunction_GetAnnotations() functi…
befa954 
…on (GH-144630) (#144670)

gh-144629: Add test for the PyFunction_GetAnnotations() function (GH-144630)
(cherry picked from commit cc81707)

Co-authored-by: Nybblista <170842536+nybblista@users.noreply.github.com>
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
pythongh-144629: Add test for the PyFunction_GetAnnotations() function (
436181f 
python#144630)
brijkapadia pushed a commit to brijkapadia/cpython that referenced this pull request Feb 28, 2026
pythongh-144629: Add test for the PyFunction_GetAnnotations() function (
4601e9c 
python#144630)
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
pythongh-144629: Add test for the PyFunction_GetAnnotations() function (
b18331d 
python#144630)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
ZeroIntensity Awaiting requested review from ZeroIntensity

Assignees

vstinner

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL