FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Disable pip version check when upgrading certifi by hugovk · Pull Request #144632 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

Disable pip version check when upgrading certifi - #144632

Merged
ned-deily merged 1 commit into
python:mainfrom
hugovk:3.15-disable-pip-version-check
Feb 10, 2026
ConversationCommits (1)ChecksFiles changed
Merged

Disable pip version check when upgrading certifi#144632
ned-deily merged 1 commit into
python:mainfrom
hugovk:3.15-disable-pip-version-check

Conversation

hugovk commented Feb 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This PR adds --disable-pip-version-check to the pip invocation that upgrades certifi in Install Certificates.command, to avoid warnings like this:

[notice] A new release of pip is available: 25.3 -> 26.0.1
[notice] To update, run: /Library/Frameworks/Python.framework/Versions/3.14/bin/python3.14 -m pip install --upgrade pip

Docs: https://pip.pypa.io/en/stable/cli/pip/#cmdoption-disable-pip-version-check

These sometimes show up on GitHub Actions as part of actions/setup-python, which I as an end user has little control over. And the funny thing is, that action had just upgraded pip right before calling Install Certificates.command. See python-pillow/Pillow#9424 (comment) for more details.

I think avoiding the warning in this script is okay. In normal use, the user double clicks the "Install Certificates.command" icon during installation, the default terminal upgrades certifi then terminates.

People will still see the warning later on regular pip invocations when they're in a normal terminal session, which is when they can actually do something about it.

(Let me know if this PR needs an issue or news.)

hugovk requested a review from a team as a code owner February 9, 2026 15:19
ned-deily merged commit 80ba4e1 into python:main Feb 10, 2026
43 checks passed
ned-deily added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Feb 10, 2026

miss-islington-app Bot commented Feb 10, 2026

Copy link
Copy Markdown

Thanks @hugovk for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app Bot commented Feb 10, 2026

Copy link
Copy Markdown

Thanks @hugovk for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 10, 2026
Disable pip version check when upgrading certifi (pythonGH-144632)
12ab1b9 
(cherry picked from commit 80ba4e1)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 10, 2026
Disable pip version check when upgrading certifi (pythonGH-144632)
78d8ded 
(cherry picked from commit 80ba4e1)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

bedevere-app Bot commented Feb 10, 2026

Copy link
Copy Markdown

GH-144640 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Feb 10, 2026

bedevere-app Bot commented Feb 10, 2026

Copy link
Copy Markdown

GH-144641 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Feb 10, 2026
ned-deily pushed a commit that referenced this pull request Feb 10, 2026
[3.13] Disable pip version check when upgrading certifi (GH-144632) (#…
de105e7 
…144640)

(cherry picked from commit 80ba4e1)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
ned-deily pushed a commit that referenced this pull request Feb 10, 2026
[3.14] Disable pip version check when upgrading certifi (GH-144632) (#…
3fc48c1 
…144641)

(cherry picked from commit 80ba4e1)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

bedevere-bot commented Feb 10, 2026

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.x (tier-1) has failed when building commit 80ba4e1.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/345/builds/13374) and take a look at the build logs.
  4. Check if the failure is related to this commit (80ba4e1) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/345/builds/13374

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 947, in gc_collect
    gc.collect()
    ~~~~~~~~~~^^
ResourceWarning: unclosed file <_io.FileIO name=13 mode='wb' closefd=True>

hugovk deleted the 3.15-disable-pip-version-check branch February 10, 2026 09:44
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
Disable pip version check when upgrading certifi (python#144632)
463f043
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
Disable pip version check when upgrading certifi (python#144632)
d9ab47f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ned-deily ned-deily approved these changes

Assignees

No one assigned

Labels

OS-mac skip issue skip news topic-installation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL