FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-144639: Ruff: target Python 3.14 syntax in `Lib/test` by hugovk · Pull Request #144656 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-144639: Ruff: target Python 3.14 syntax in Lib/test - #144656

Merged
AA-Turner merged 3 commits into
python:mainfrom
hugovk:lib-test-ruff
Feb 11, 2026
ConversationCommits (3)ChecksFiles changed
Merged

gh-144639: Ruff: target Python 3.14 syntax in Lib/test#144656
AA-Turner merged 3 commits into
python:mainfrom
hugovk:lib-test-ruff

Conversation

hugovk commented Feb 10, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Feb 10, 2026
Closed
picnixz reviewed Feb 10, 2026
View reviewed changes

picnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I would suggest that we keep the old syntax but keep the ruff update. Btw ISTM that this new syntax is similar to the old print syntax which was then replaced by the () form so I still struggle to parse this.

Comment thread Lib/test/support/import_helper.py
hugovk marked this pull request as ready for review February 10, 2026 10:53
AlexWaygood approved these changes Feb 10, 2026
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I like the new syntax: it means less noisy punctuation, and it's similar to the way that tuples don't need parentheses to be tuples.

Comment thread Lib/test/.ruff.toml
Add comment to explain target-version
d97cd97 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

picnixz commented Feb 10, 2026

Copy link
Copy Markdown
Member

I like the new syntax: it means less noisy punctuation, and it's similar to the way that tuples don't need parentheses to be tuples.

Yeah this kind of syntax is also annoying for me except for destructuring... (I always put parentheses around my tuples except when doing a x, y = ...) At least we agree on not agreeing! I won't block on that change (though I think it's preferrable if we decide which syntax to use because while less noisy it is still hard without it for me to read it (the comma looks like I'm done with my line so my eyes don't parse afterwards. With parentheses, I know I need to find the other closing parenthesis).

hugovk commented Feb 10, 2026

Copy link
Copy Markdown
Member Author

I think the SC accepting PEP 758 is a pretty good signal that it's okay to use :) This is modern Python.

With parentheses, I know I need to find the other closing parenthesis).

Ironically, your full last comment has three opening parentheses, but only two closing ones! Or perhaps an argument for using fewer parentheses ;)

picnixz commented Feb 10, 2026

Copy link
Copy Markdown
Member

Ironically, your full last comment has three opening parentheses, but only two closing ones! Or perhaps an argument for using fewer parentheses ;)

Yeah I saw that! well it is an argument for using fewer but it won't help me when reading (when writing it could!)

picnixz commented Feb 10, 2026

Copy link
Copy Markdown
Member

Btw, the only place where I found the missing parentheses in tuples was in the stdlib. I didn't see other codes doing it actually so I never knew about it! (I only learned about it when looking at our tests...)

AlexWaygood commented Feb 10, 2026

Copy link
Copy Markdown
Member

Btw, the only place where I found the missing parentheses in tuples was in the stdlib. I didn't see other codes doing it actually so I never knew about it! (I only learned about it when looking at our tests...)

Huh, I think it's fairly common to do for a, b in my_dict.items(): ...

AA-Turner approved these changes Feb 11, 2026
View reviewed changes
Comment thread Lib/test/.ruff.toml Outdated
Comment thread Lib/test/.ruff.toml
Apply suggestion from AA-Turner
c7fa4b5 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
hugovk added the needs backport to 3.14 bugs and security fixes label Feb 11, 2026
AA-Turner merged commit 81484c5 into python:main Feb 11, 2026
47 checks passed

miss-islington-app Bot commented Feb 11, 2026

Copy link
Copy Markdown

Thanks @hugovk for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington-app Bot commented Feb 11, 2026

Copy link
Copy Markdown

Sorry, @hugovk and @AA-Turner, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 81484c5629f9d8b698a2be58f850a0e4efe48ed3 3.14

hugovk deleted the lib-test-ruff branch February 11, 2026 14:18
hugovk added a commit to hugovk/cpython that referenced this pull request Feb 11, 2026
[3.14] pythongh-144639: Ruff: target Python 3.14 syntax in Lib/test (…
c6dc437 
…pythonGH-144656)

(cherry picked from commit 81484c5)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

bedevere-app Bot commented Feb 11, 2026

Copy link
Copy Markdown

GH-144710 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Feb 11, 2026
hugovk added a commit that referenced this pull request Feb 11, 2026
[3.14] gh-144639: Ruff: target Python 3.14 syntax in Lib/test (GH-1…
bbd682d 
…44656) (#144710)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
pythongh-144639: Ruff: target Python 3.14 syntax in Lib/test (pytho…
498416c 
…n#144656)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
brijkapadia pushed a commit to brijkapadia/cpython that referenced this pull request Feb 28, 2026
pythongh-144639: Ruff: target Python 3.14 syntax in Lib/test (pytho…
25ce2a3 
…n#144656)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
pythongh-144639: Ruff: target Python 3.14 syntax in Lib/test (pytho…
3461a89 
…n#144656)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AlexWaygood AlexWaygood approved these changes
AA-Turner AA-Turner approved these changes
picnixz picnixz approved these changes
johnslavik johnslavik approved these changes
brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

AA-Turner

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL