FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.14] gh-138744: Upgrade Windows to 2025 in GitHub Actions by vstinner · Pull Request #144669 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

[3.14] gh-138744: Upgrade Windows to 2025 in GitHub Actions - #144669

Closed
vstinner wants to merge 2 commits into
python:3.14from
vstinner:windows_2025
ConversationCommits (2)ChecksFiles changed
Closed

[3.14] gh-138744: Upgrade Windows to 2025 in GitHub Actions#144669
vstinner wants to merge 2 commits into
python:3.14from
vstinner:windows_2025

Conversation

vstinner commented Feb 10, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Replace windows-2022 with windows-2025.

bedevere-app Bot mentioned this pull request Feb 10, 2026
Closed

vstinner commented Feb 10, 2026

Copy link
Copy Markdown
Member Author

I skipped test_dtrace on Windows in the 3.14 branch: #144657. So tests should pass again on Windows 2025.

vstinner commented Feb 10, 2026

Copy link
Copy Markdown
Member Author

cc @Fidget-Spinner

vstinner marked this pull request as draft February 10, 2026 14:50

vstinner commented Feb 10, 2026

Copy link
Copy Markdown
Member Author

The Windows CI was skipped since my PR only modify files of the .github/ directory. I mark my PR as a draft and modify a random file (Lib/test/test_dtrace.py) to trigger the Windows CI.

vstinner commented Feb 10, 2026

Copy link
Copy Markdown
Member Author

All Windows CIs passed. Examples:

JIT / i686-pc-windows-msvc/msvc (Debug) (pull_request)
JIT / i686-pc-windows-msvc/msvc (Release) (pull_request)
JIT / x86_64-pc-windows-msvc/msvc (Debug) (pull_request)
JIT / x86_64-pc-windows-msvc/msvc (Release) (pull_request)
Tail calling interpreter / x86_64-pc-windows-msvc/msvc (pull_request)
Tests / Windows (free-threading) / Build and test (arm64) (pull_request)
Tests / Windows (free-threading) / Build and test (x64) (pull_request)
Tests / Windows / Build and test (arm64) (pull_request)
Tests / Windows / Build and test (Win32) (pull_request)
Tests / Windows / Build and test (x64) (pull_request)
Tests / Windows MSI / installer for arm64 (pull_request)
Tests / Windows MSI / installer for x64 (pull_request)
Tests / Windows MSI / installer for x86 (pull_request)

hugovk reviewed Feb 10, 2026
View reviewed changes
Comment thread .github/workflows/tail-call.yml
Comment thread .github/workflows/reusable-windows-msi.yml
build:
name: installer for ${{ inputs.arch }}
runs-on: ${{ inputs.arch == 'arm64' && 'windows-11-arm' || 'windows-2022' }}
runs-on: ${{ inputs.arch == 'arm64' && 'windows-11-arm' || 'windows-2025' }}

hugovk Feb 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Also make this change in main?

Comment thread .github/workflows/reusable-windows.yml
build:
name: Build and test (${{ inputs.arch }})
runs-on: ${{ inputs.arch == 'arm64' && 'windows-11-arm' || 'windows-2022' }}
runs-on: ${{ inputs.arch == 'arm64' && 'windows-11-arm' || 'windows-2025' }}

hugovk Feb 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

And this in main?

Comment thread .github/workflows/jit.yml
- target: i686-pc-windows-msvc/msvc
architecture: Win32
runner: windows-2022
runner: windows-2025

hugovk Feb 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Also this in main?

Comment thread .github/workflows/jit.yml
- target: x86_64-pc-windows-msvc/msvc
architecture: x64
runner: windows-2022
runner: windows-2025

hugovk Feb 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

And this?

vstinner commented Feb 10, 2026

Copy link
Copy Markdown
Member Author

Oh, I misunderstood the commit 25e99b3. I expected that it already upgraded Windows to 2025 for all CI jobs, but in fact it only changes "Windows tailcall CI".

I closed this PR to redo the change in the main branch first: #144682.

vstinner closed this Feb 10, 2026
vstinner deleted the windows_2025 branch July 10, 2026 20:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ambv ambv left review comments
hugovk hugovk left review comments
StanFromIreland StanFromIreland left review comments
webknjaz webknjaz approved these changes
brandtbucher Awaiting requested review from brandtbucher brandtbucher is a code owner
savannahostrowski Awaiting requested review from savannahostrowski
ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL