FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-66305: Fix a hang on Windows in the tempfile module by serhiy-storchaka · Pull Request #144672 · python/cpython · GitHub

/ cpython Public

gh-66305: Fix a hang on Windows in the tempfile module - #144672

Merged
serhiy-storchaka merged 7 commits into
python:mainfrom
serhiy-storchaka:tempfile-hangs-on-bad-tempdir
Feb 24, 2026
ConversationCommits (7)ChecksFiles changed
Merged

gh-66305: Fix a hang on Windows in the tempfile module#144672
serhiy-storchaka merged 7 commits into
python:mainfrom
serhiy-storchaka:tempfile-hangs-on-bad-tempdir

Conversation

serhiy-storchaka commented Feb 10, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

It occurred when trying to create a temporary file or subdirectory in a non-writable directory.

pythongh-66305: Fix a hang for a few seconds on Windows in the tempfi…
5753c73 
…le module

It occurred when trying to create a temporary file or subdirectory in
a non-writable directory.
serhiy-storchaka requested a review from a team February 10, 2026 14:58
serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Feb 10, 2026
bedevere-app Bot mentioned this pull request Feb 10, 2026
Closed

serhiy-storchaka commented Feb 10, 2026

Copy link
Copy Markdown
Member Author

Reducing the number of attempts should help, but I have not tested yet.

serhiy-storchaka force-pushed the tempfile-hangs-on-bad-tempdir branch from 77ade1f to ac17d9e Compare February 10, 2026 19:26
serhiy-storchaka changed the title gh-66305: Fix a hang for a few seconds on Windows in the tempfile module gh-66305: Fix a hang on Windows in the tempfile module Feb 10, 2026

serhiy-storchaka commented Feb 10, 2026

Copy link
Copy Markdown
Member Author

Tested on Windows. There was a test for readonly tempdir, but it was always skipped on Windows. It was not for a few seconds, but for about 10 days (for estimations). Now the test correctly works on Windows.

serhiy-storchaka marked this pull request as ready for review February 10, 2026 19:43
serhiy-storchaka merged commit ca66d3c into python:main Feb 24, 2026
47 checks passed

miss-islington-app Bot commented Feb 24, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

serhiy-storchaka deleted the tempfile-hangs-on-bad-tempdir branch February 24, 2026 11:05
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 24, 2026
pythongh-66305: Fix a hang on Windows in the tempfile module (pythonG…
9644041 
…H-144672)

It occurred when trying to create a temporary file or subdirectory in
a non-writable directory.
(cherry picked from commit ca66d3c)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 24, 2026
pythongh-66305: Fix a hang on Windows in the tempfile module (pythonG…
115c28f 
…H-144672)

It occurred when trying to create a temporary file or subdirectory in
a non-writable directory.
(cherry picked from commit ca66d3c)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

bedevere-app Bot commented Feb 24, 2026

Copy link
Copy Markdown

GH-145168 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Feb 24, 2026

bedevere-app Bot commented Feb 24, 2026

Copy link
Copy Markdown

GH-145169 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Feb 24, 2026
serhiy-storchaka added a commit that referenced this pull request Feb 24, 2026
[3.14] gh-66305: Fix a hang on Windows in the tempfile module (GH-144672
da03b36 
) (GH-145168)

It occurred when trying to create a temporary file or subdirectory in
a non-writable directory.
(cherry picked from commit ca66d3c)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Feb 24, 2026
[3.13] gh-66305: Fix a hang on Windows in the tempfile module (GH-144672
cb1d20b 
) (GH-145169)

It occurred when trying to create a temporary file or subdirectory in
a non-writable directory.
(cherry picked from commit ca66d3c)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
brijkapadia pushed a commit to brijkapadia/cpython that referenced this pull request Feb 28, 2026
pythongh-66305: Fix a hang on Windows in the tempfile module (pythonG…
79b918d 
…H-144672)

It occurred when trying to create a temporary file or subdirectory in
a non-writable directory.
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
pythongh-66305: Fix a hang on Windows in the tempfile module (pythonG…
90976f2 
…H-144672)

It occurred when trying to create a temporary file or subdirectory in
a non-writable directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gpshead Awaiting requested review from gpshead
zooba Awaiting requested review from zooba

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL