FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-141563: Enable test_cppext internal C API tests on macOS by vstinner · Pull Request #144711 · python/cpython · GitHub

/ cpython Public

gh-141563: Enable test_cppext internal C API tests on macOS - #144711

Merged
vstinner merged 2 commits into
python:mainfrom
vstinner:test_cppext_macos
Feb 11, 2026
ConversationCommits (2)ChecksFiles changed
Merged

gh-141563: Enable test_cppext internal C API tests on macOS#144711
vstinner merged 2 commits into
python:mainfrom
vstinner:test_cppext_macos

Conversation

vstinner commented Feb 11, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Build the C API in C++11 mode on macOS.

bedevere-app Bot mentioned this pull request Feb 11, 2026
Closed

vstinner commented Feb 11, 2026

Copy link
Copy Markdown
Member Author

!buildbot x86-64 MacOS Intel NoGIL

bedevere-bot commented Feb 11, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @vstinner for commit 15ab9d4 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F144711%2Fmerge

The command will test the builders whose names match following regular expression: x86-64 MacOS Intel NoGIL

The builders matched are:

  • x86-64 MacOS Intel NoGIL PR

vstinner commented Feb 11, 2026

Copy link
Copy Markdown
Member Author

It doesn't work, there are many C++ compiler warnings. But I didn't expect -pedantic-errors in C++ compiler flags.

  clang++ -fno-strict-overflow -Wsign-compare -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -g -Og -Wall -I/Users/buildbot/buildarea/pull_request.itamaro-macos-intel-aws.nogil/build/build/test_python_11425æ/tempcwd/env/include -I/Users/buildbot/buildarea/pull_request.itamaro-macos-intel-aws.nogil/build/Include -I/Users/buildbot/buildarea/pull_request.itamaro-macos-intel-aws.nogil/build -c extension.cpp -o build/temp.macosx-13.7-x86_64-cpython-315t-pydebug/extension.o -Werror -DMODULE_NAME=_testcppext_internal -std=c++11 -pedantic-errors -Wno-long-long -DTEST_INTERNAL_C_API=1

  In file included from extension.cpp:21:
  In file included from /Users/buildbot/buildarea/pull_request.itamaro-macos-intel-aws.nogil/build/Include/internal/pycore_backoff.h:15:
  In file included from /Users/buildbot/buildarea/pull_request.itamaro-macos-intel-aws.nogil/build/Include/internal/pycore_interp_structs.h:15:
  In file included from /Users/buildbot/buildarea/pull_request.itamaro-macos-intel-aws.nogil/build/Include/internal/pycore_tstate.h:15:
  /Users/buildbot/buildarea/pull_request.itamaro-macos-intel-aws.nogil/build/Include/internal/pycore_qsbr.h:75:20: error: zero size arrays are an extension [-Werror,-Wzero-length-array]
      char __padding[64 - sizeof(struct _qsbr_thread_state)];
                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  In file included from extension.cpp:21:
  In file included from /Users/buildbot/buildarea/pull_request.itamaro-macos-intel-aws.nogil/build/Include/internal/pycore_backoff.h:15:
  In file included from /Users/buildbot/buildarea/pull_request.itamaro-macos-intel-aws.nogil/build/Include/internal/pycore_interp_structs.h:15:
  In file included from /Users/buildbot/buildarea/pull_request.itamaro-macos-intel-aws.nogil/build/Include/internal/pycore_tstate.h:16:
  /Users/buildbot/buildarea/pull_request.itamaro-macos-intel-aws.nogil/build/Include/internal/pycore_uop.h:26:9: error: anonymous structs are a GNU extension [-Werror,-Wgnu-anonymous-struct]
          struct {
          ^
  /Users/buildbot/buildarea/pull_request.itamaro-macos-intel-aws.nogil/build/Include/internal/pycore_uop.h:26:9: error: anonymous types declared in an anonymous union are an extension [-Werror,-Wnested-anon-types]
  In file included from extension.cpp:21:
  /Users/buildbot/buildarea/pull_request.itamaro-macos-intel-aws.nogil/build/Include/internal/pycore_backoff.h:65:13: error: compound literals are a C99-specific feature [-Werror,-Wc99-extensions]
      return ((_Py_BackoffCounter){
              ^
  /Users/buildbot/buildarea/pull_request.itamaro-macos-intel-aws.nogil/build/Include/internal/pycore_backoff.h:83:13: error: compound literals are a C99-specific feature [-Werror,-Wc99-extensions]
      return ((_Py_BackoffCounter){
              ^
  In file included from extension.cpp:22:
  In file included from /Users/buildbot/buildarea/pull_request.itamaro-macos-intel-aws.nogil/build/Include/internal/pycore_cell.h:5:
  In file included from /Users/buildbot/buildarea/pull_request.itamaro-macos-intel-aws.nogil/build/Include/internal/pycore_object.h:15:
  In file included from /Users/buildbot/buildarea/pull_request.itamaro-macos-intel-aws.nogil/build/Include/internal/pycore_runtime.h:11:
  In file included from /Users/buildbot/buildarea/pull_request.itamaro-macos-intel-aws.nogil/build/Include/internal/pycore_runtime_structs.h:62:
  /Users/buildbot/buildarea/pull_request.itamaro-macos-intel-aws.nogil/build/Include/internal/pycore_tracemalloc.h:63:30: error: flexible array members are a C99 feature [-Werror,-Wc99-extensions]
      struct tracemalloc_frame frames[];
                               ^
  In file included from extension.cpp:22:
  In file included from /Users/buildbot/buildarea/pull_request.itamaro-macos-intel-aws.nogil/build/Include/internal/pycore_cell.h:6:
  /Users/buildbot/buildarea/pull_request.itamaro-macos-intel-aws.nogil/build/Include/internal/pycore_stackref.h:388:12: error: compound literals are a C99-specific feature [-Werror,-Wc99-extensions]
      return (_PyStackRef){ .bits = ((uintptr_t)ptr) | Py_TAG_INVALID };
             ^
  /Users/buildbot/buildarea/pull_request.itamaro-macos-intel-aws.nogil/build/Include/internal/pycore_stackref.h:435:12: error: compound literals are a C99-specific feature [-Werror,-Wc99-extensions]
      return (_PyStackRef){ .bits = ((((uintptr_t)i) << Py_TAGGED_SHIFT) | Py_INT_TAG) };
             ^
  /Users/buildbot/buildarea/pull_request.itamaro-macos-intel-aws.nogil/build/Include/internal/pycore_stackref.h:452:12: error: compound literals are a C99-specific feature [-Werror,-Wc99-extensions]
      return (_PyStackRef){ .bits = ref.bits + (1 << Py_TAGGED_SHIFT) };
             ^
  /Users/buildbot/buildarea/pull_request.itamaro-macos-intel-aws.nogil/build/Include/internal/pycore_stackref.h:534:12: error: compound literals are a C99-specific feature [-Werror,-Wc99-extensions]
      return (_PyStackRef){ .bits = ref.bits | Py_TAG_REFCNT };
             ^
  /Users/buildbot/buildarea/pull_request.itamaro-macos-intel-aws.nogil/build/Include/internal/pycore_stackref.h:556:12: error: compound literals are a C99-specific feature [-Werror,-Wc99-extensions]
      return (_PyStackRef){ .bits = (uintptr_t)obj };
             ^
  /Users/buildbot/buildarea/pull_request.itamaro-macos-intel-aws.nogil/build/Include/internal/pycore_stackref.h:574:23: error: compound literals are a C99-specific feature [-Werror,-Wc99-extensions]
      _PyStackRef ref = (_PyStackRef){ .bits = (uintptr_t)obj };
                        ^
  /Users/buildbot/buildarea/pull_request.itamaro-macos-intel-aws.nogil/build/Include/internal/pycore_stackref.h:585:16: error: compound literals are a C99-specific feature [-Werror,-Wc99-extensions]
          return (_PyStackRef){ .bits = (uintptr_t)obj | Py_TAG_REFCNT };
                 ^
  /Users/buildbot/buildarea/pull_request.itamaro-macos-intel-aws.nogil/build/Include/internal/pycore_stackref.h:593:23: error: compound literals are a C99-specific feature [-Werror,-Wc99-extensions]
      _PyStackRef ref = (_PyStackRef){ .bits = (uintptr_t)obj };
                        ^
  /Users/buildbot/buildarea/pull_request.itamaro-macos-intel-aws.nogil/build/Include/internal/pycore_stackref.h:604:23: error: compound literals are a C99-specific feature [-Werror,-Wc99-extensions]
      _PyStackRef ref = (_PyStackRef){ .bits = (uintptr_t)obj };
                        ^
  /Users/buildbot/buildarea/pull_request.itamaro-macos-intel-aws.nogil/build/Include/internal/pycore_stackref.h:615:12: error: compound literals are a C99-specific feature [-Werror,-Wc99-extensions]
      return (_PyStackRef){ .bits = (uintptr_t)obj | Py_TAG_REFCNT};
             ^
  /Users/buildbot/buildarea/pull_request.itamaro-macos-intel-aws.nogil/build/Include/internal/pycore_stackref.h:801:16: error: compound literals are a C99-specific feature [-Werror,-Wc99-extensions]
          *out = (_PyStackRef){ .bits = (uintptr_t)op | Py_TAG_REFCNT };
                 ^
  17 errors generated.

vstinner commented Feb 11, 2026

Copy link
Copy Markdown
Member Author

!buildbot x86-64 MacOS Intel NoGIL

bedevere-bot commented Feb 11, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @vstinner for commit 68ae13f 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F144711%2Fmerge

The command will test the builders whose names match following regular expression: x86-64 MacOS Intel NoGIL

The builders matched are:

  • x86-64 MacOS Intel NoGIL PR

vstinner commented Feb 11, 2026

Copy link
Copy Markdown
Member Author

Aha, it works with -std=c++11 and without -pedantic-errors: tests passed successfully on buildbot/x86-64 MacOS Intel NoGIL PR.

vstinner marked this pull request as ready for review February 11, 2026 15:28
vstinner added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 11, 2026

bedevere-bot commented Feb 11, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @vstinner for commit 68ae13f 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F144711%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 11, 2026

ned-deily commented Feb 11, 2026

Copy link
Copy Markdown
Member

Aha, it works with -std=c++11 and without -pedantic-errors: tests passed successfully on buildbot/x86-64 MacOS Intel NoGIL PR.

And it passed on the test system that was failing yesterday. Thank you!

vstinner merged commit c6e418d into python:main Feb 11, 2026
107 of 110 checks passed
vstinner deleted the test_cppext_macos branch February 11, 2026 17:38
vstinner added a commit to vstinner/cpython that referenced this pull request Feb 12, 2026
pythongh-141563: Enable test_cppext internal C API tests on macOS (py…
ecb0f3e 
…thon#144711)

Build the C API in C++11 mode on macOS.

(cherry picked from commit c6e418d)
vstinner added a commit that referenced this pull request Feb 13, 2026
[3.14] gh-135906: Test more internal headers in test_cext/test_cppext (…
c11e70a 
…#144758)

* gh-141563: Enable test_cppext internal C API tests on macOS (#144711)

Build the C API in C++11 mode on macOS.

(cherry picked from commit c6e418d)

* gh-135906: Test more internal headers in test_cext/test_cppext (#144751)

(cherry picked from commit b488f33)
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
pythongh-141563: Enable test_cppext internal C API tests on macOS (py…
d2bfb17 
…thon#144711)

Build the C API in C++11 mode on macOS.
brijkapadia pushed a commit to brijkapadia/cpython that referenced this pull request Feb 28, 2026
pythongh-141563: Enable test_cppext internal C API tests on macOS (py…
974cbd7 
…thon#144711)

Build the C API in C++11 mode on macOS.
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
pythongh-141563: Enable test_cppext internal C API tests on macOS (py…
74fa82e 
…thon#144711)

Build the C API in C++11 mode on macOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ned-deily ned-deily approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL