FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-122622: Add sys._preexec hook for REPL by anthonykim1 · Pull Request #144724 · python/cpython · GitHub

/ cpython Public
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension .py  (2) .rst  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
7 changes: 7 additions & 0 deletions Lib/_pyrepl/simple_interact.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,13 @@ def maybe_run_command(statement: str) -> bool:
if maybe_run_command(statement):
continue

preexec = getattr(sys, "_preexec", None)
if callable(preexec):
try:
preexec(statement)
except Exception:
pass

input_name = f"<python-input-{input_n}>"
more = console.push(_strip_final_indent(statement), filename=input_name, _symbol="single") # type: ignore[call-arg]
assert not more
Expand Down
53 changes: 52 additions & 1 deletion Lib/test/test_pyrepl/test_interact.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import contextlib
import io
import sys
import warnings
import unittest
from unittest.mock import patch
from unittest.mock import patch, MagicMock
from textwrap import dedent

from test.support import force_not_colorized
Expand Down Expand Up @@ -299,3 +300,53 @@ def f():
count = sum("'return' in a 'finally' block" in str(w.message)
for w in caught)
self.assertEqual(count, 1)


class TestPreexecHook(unittest.TestCase):

def _run_interactive(self, statements, *, preexec=None):
from _pyrepl.simple_interact import run_multiline_interactive_console

console = InteractiveColoredConsole()
statement_iter = iter(statements)

def fake_multiline_input(more_lines, ps1, ps2):
try:
return next(statement_iter)
except StopIteration:
raise EOFError

patches = [
patch("_pyrepl.simple_interact.multiline_input", side_effect=fake_multiline_input),
patch("_pyrepl.simple_interact._get_reader"),
patch("_pyrepl.simple_interact.append_history_file"),
patch("_pyrepl.readline._setup"),
]
if preexec is not None:
patches.append(patch.object(sys, "_preexec", preexec, create=True))

f = io.StringIO()
with contextlib.ExitStack() as stack:
for p in patches:
stack.enter_context(p)
stack.enter_context(contextlib.redirect_stdout(f))
stack.enter_context(contextlib.redirect_stderr(f))
run_multiline_interactive_console(console)

return f.getvalue()

def test_preexec_called_with_statement(self):
preexec = MagicMock()
self._run_interactive(["x = 1"], preexec=preexec)
preexec.assert_called_once_with("x = 1")

def test_preexec_exception_does_not_break_repl(self):
def bad_preexec(cmd):
raise RuntimeError("hook error")

self._run_interactive(["x = 1", "y = 2"], preexec=bad_preexec)

def test_preexec_not_called_for_repl_commands(self):
preexec = MagicMock()
self._run_interactive(["clear"], preexec=preexec)
preexec.assert_not_called()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Add ``sys._preexec`` hook that is called with the command line string
before each statement is executed in the interactive REPL. This allows
external tools to implement features such as shell integration.
Loading

Back | FazBrowse Home | New Git URL