Repository navigation
gh-101178: Fix possible integer overflow in Ascii85 encoder with wrapcol=1 - #144778
Merged
serhiy-storchaka merged 1 commit intoFeb 24, 2026
Merged
serhiy-storchaka merged 1 commit into
serhiy-storchaka merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…h wrapcol=1 It could happen if the size of the input is more than 4/5 of sys.maxsize (only feasible on 32-bit platforms). Also simplify the integer overflow checks in the Base64 encoder, and harmonize them with the code for Ascii85 and Base85.
sethmlarson
reviewed
Feb 13, 2026
Comment thread
Modules/binascii.c
| out_len -= 4 - (bin_len % 4); | ||
| } | ||
| if (wrapcol && out_len) { | ||
| if (wrapcol && out_len && out_len <= PY_SSIZE_T_MAX) { |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Let me know if I'm misunderstanding, but wouldn't we need to "error out" if the out_len would overflow here instead of not expanding? The larger amount of data will still be written outside ascii_data whether out_len is expanded or not?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
We error out in the next "if".
Sorry, something went wrong.
brijkapadia
pushed a commit
to brijkapadia/cpython
that referenced
this pull request
Feb 28, 2026
…h wrapcol=1 (pythonGH-144778) It could happen if the size of the input is more than 4/5 of sys.maxsize (only feasible on 32-bit platforms). Also simplify the integer overflow checks in the Base64 encoder, and harmonize them with the code for Ascii85 and Base85.
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
…h wrapcol=1 (pythonGH-144778) It could happen if the size of the input is more than 4/5 of sys.maxsize (only feasible on 32-bit platforms). Also simplify the integer overflow checks in the Base64 encoder, and harmonize them with the code for Ascii85 and Base85.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It could happen if the size of the input is more than 4/5 of sys.maxsize (only feasible on 32-bit platforms).
Also simplify the integer overflow checks in the Base64 encoder, and harmonize them with the code for Ascii85 and Base85.