Repository navigation
gh-142224: makeunicodedata.py: parse default bidi values - #144815
Merged
serhiy-storchaka merged 5 commits intoFeb 18, 2026
Merged
serhiy-storchaka merged 5 commits into
serhiy-storchaka merged 5 commits into
Conversation
serhiy-storchaka
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I was going to work on this issue next week, but you saved my time. Thank you.
Sorry, something went wrong.
Comment thread
Tools/unicode/makeunicodedata.py
Outdated
Comment thread
Tools/unicode/makeunicodedata.py
Outdated
Comment thread
Tools/unicode/makeunicodedata.py
Outdated
# Conflicts: # Lib/test/test_unicodedata.py # Tools/unicode/makeunicodedata.py
Comment thread
Tools/unicode/makeunicodedata.py
Outdated
Comment thread
Tools/unicode/makeunicodedata.py
Outdated
Copy link
Copy Markdown
Member
|
Sorry, I don't have time for a true review. From a casual look, this LGTM, though. |
Sorry, something went wrong.
serhiy-storchaka
approved these changes
Feb 18, 2026
serhiy-storchaka
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM. 👍
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @StanFromIreland for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @StanFromIreland for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, @StanFromIreland and @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict. cherry_picker e49bfca87cc188c271946491edc33831a901c7f1 3.13 |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, @StanFromIreland and @serhiy-storchaka, I could not cleanly backport this to 3.14 due to a conflict. cherry_picker e49bfca87cc188c271946491edc33831a901c7f1 3.14 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I am not sure if it is worth to backport this. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
No worries, thanks for the reviews.
Yes, I would think it is an uncommon issue. |
Sorry, something went wrong.
brijkapadia
pushed a commit
to brijkapadia/cpython
that referenced
this pull request
Feb 28, 2026
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
encukou
added a commit
to encukou/cpython
that referenced
this pull request
Aug 18, 2026
encukou
added a commit
that referenced
this pull request
Sep 4, 2026
… RFC 3454 (GH-155293) (GH-156020) Due to a bug, some Unicode codepoint attributes were considered for characters not yet defined in Unicode 3.2.0 or attributes which changed in later Unicode versions. RFC 3454 (StringPrep) requires using Unicode 3.2.0 strictly. (cherry picked from commit 7e109d0) The cherry-pick needed reworking as GH-144815 wasn't backported to 3.14 and below, so unassigned characters don't have bidi values. Co-authored-by: Seth Larson <seth@python.org> Co-authored-by: Stan Ulbrych <89152624+stanfromireland@users.noreply.github.com> Co-authored-by: Petr Viktorin <encukou@gmail.com>
This was referenced Sep 4, 2026
Yhg1s
pushed a commit
that referenced
this pull request
Sep 8, 2026
… RFC 3454 (GH-155293) (GH-156020) (#156930) Due to a bug, some Unicode codepoint attributes were considered for characters not yet defined in Unicode 3.2.0 or attributes which changed in later Unicode versions. RFC 3454 (StringPrep) requires using Unicode 3.2.0 strictly. (cherry picked from commit 7e109d0) The cherry-pick needed reworking as GH-144815 wasn't backported to 3.14 and below, so unassigned characters don't have bidi values. (cherry picked from commit 1e54caa) Also, add Unicode_3_2_0_FunctionsTest as in the later versions, to make the new test work. Co-authored-by: Seth Larson seth@python.org Co-authored-by: Stan Ulbrych 89152624+stanfromireland@users.noreply.github.com Co-authored-by: Petr Viktorin encukou@gmail.com
encukou
added a commit
that referenced
this pull request
Sep 9, 2026
… RFC 3454 (GH-155293) (GH-156020) (GH-156922) Due to a bug, some Unicode codepoint attributes were considered for characters not yet defined in Unicode 3.2.0 or attributes which changed in later Unicode versions. RFC 3454 (StringPrep) requires using Unicode 3.2.0 strictly. (cherry picked from commit 7e109d0) The cherry-pick needed reworking as GH-144815 wasn't backported to 3.14 and below, so unassigned characters don't have bidi values. (cherry picked from commit 1e54caa) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Seth Larson <seth@python.org> Co-authored-by: Stan Ulbrych <89152624+stanfromireland@users.noreply.github.com> Co-authored-by: Petr Viktorin <encukou@gmail.com> --------- Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Seth Larson <seth@python.org> Co-authored-by: Stan Ulbrych <89152624+stanfromireland@users.noreply.github.com>
pablogsal
pushed a commit
that referenced
this pull request
Oct 1, 2026
… RFC 3454 (GH-155293) (GH-156020) (#156932) * [3.10] gh-155292: Don't consider Unicode codepoint attributes outside RFC 3454 (GH-155293) (GH-156020) Due to a bug, some Unicode codepoint attributes were considered for characters not yet defined in Unicode 3.2.0 or attributes which changed in later Unicode versions. RFC 3454 (StringPrep) requires using Unicode 3.2.0 strictly. (cherry picked from commit 7e109d0) The cherry-pick needed reworking as GH-144815 wasn't backported to 3.14 and below, so unassigned characters don't have bidi values. (cherry picked from commit 1e54caa) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Seth Larson <seth@python.org> Co-authored-by: Stan Ulbrych <89152624+stanfromireland@users.noreply.github.com> Co-authored-by: Petr Viktorin <encukou@gmail.com> * Add Unicode_3_2_0_FunctionsTest * Regenerate Unicode data --------- Co-authored-by: Seth Larson <seth@python.org> Co-authored-by: Stan Ulbrych <89152624+stanfromireland@users.noreply.github.com>
pablogsal
pushed a commit
that referenced
this pull request
Oct 1, 2026
… RFC 3454 (GH-155293) (GH-156020) (#156931) * [3.11] gh-155292: Don't consider Unicode codepoint attributes outside RFC 3454 (GH-155293) (GH-156020) Due to a bug, some Unicode codepoint attributes were considered for characters not yet defined in Unicode 3.2.0 or attributes which changed in later Unicode versions. RFC 3454 (StringPrep) requires using Unicode 3.2.0 strictly. (cherry picked from commit 7e109d0) The cherry-pick needed reworking as GH-144815 wasn't backported to 3.14 and below, so unassigned characters don't have bidi values. Co-authored-by: Seth Larson <seth@python.org> Co-authored-by: Stan Ulbrych <89152624+stanfromireland@users.noreply.github.com> Co-authored-by: Petr Viktorin <encukou@gmail.com> (cherry picked from commit 1e54caa) * Add Unicode_3_2_0_FunctionsTest * Regenerate Unicode data --------- Co-authored-by: Seth Larson <seth@python.org> Co-authored-by: Stan Ulbrych <89152624+stanfromireland@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.