Repository navigation
gh-106318: Improve str.lower() docs - #144848
adorilson wants to merge 2 commits into
Conversation
Sorry, something went wrong.
| character(s) is not "Lu" (Letter, uppercase), but e.g. "Lt" (Letter, | ||
| titlecase). | ||
|
|
||
| For example, see the word "Python" written in Punjabi, the most spoken |
There was a problem hiding this comment.
I don’t think the fact is particularly interesting nor helpful, I think it just unnecessarily extends the section.
Sorry, something went wrong.
There was a problem hiding this comment.
Do you mean the whole adding or only the example?
The note paragraph was based on what already exists in the str.upper() docs. If this exists there, I think it makes sense exist here too.
The example I've suggested adds to str.upper() docs on #144638. I would prefer a more Occidental example, but I couldn't find one. I think examples are important.
Sorry, something went wrong.
There was a problem hiding this comment.
I was referring to specifically the "most spoken language in..." fact.
Sorry, something went wrong.
There was a problem hiding this comment.
I was referring to specifically the "most spoken language in..." fact.
Sorry, something went wrong.
There was a problem hiding this comment.
Oh, nice. I've put it because if I see only "written in Punjabi", I would think "wtf is Punjabi?". Of course, I would search about that, but I thought it could be ended here.
That being said, we can:
- Keep it (in case you change your mind)
- Reduce to "written in Punjabi, a language from Paskitan"
- Reduce more to "written in Punjabi"
- 3 + adding a link to the Punjabi Wikipedia entry.
What do you prefer?
Sorry, something went wrong.
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
WIP #106318
This PR adds some details to str.lower() to make it similar to str.upper() proposed by #144638.
📚 Documentation preview 📚: https://cpython-previews--144848.org.readthedocs.build/