gh-144384: Improve _colorize performance by replacing dataclass with regular class - #144879
Closed
hugovk wants to merge 2 commits into
Closed
gh-144384: Improve _colorize performance by replacing dataclass with regular class#144879hugovk wants to merge 2 commits into
hugovk wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Marked with DO-NOT-MERGE as this approach isn't agreed upon at this point. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Closing. We can make the diff smaller by keeping the Mapping, but the better approach is to make dataclasses faster. Let's continue in the isssue. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_colorize constructs six different theme classes (and I expect more in the future), which are slow to build because they use dataclasses.
This makes the module as a whole slow to import, even the importer doesn't use a theme or doesn't use colour in the end.
If we switch to regular classes, the construction time is much faster. This PR also avoid the collections.abc import.
traceback
Below are import times for a macOS build with optimisations.
before: 15 ms
after: 6 ms
_colorize
before: 13 ms
after: ~0 ms