Repository navigation
gh-142349: Fix ast.unparse for lazy import statements - #144893
Merged
pablogsal merged 1 commit intoFeb 16, 2026
Merged
pablogsal merged 1 commit into
pablogsal merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The unparser was not handling the `is_lazy` attribute on Import and ImportFrom AST nodes, causing lazy imports to be unparsed as regular imports. This broke the round-trip (parse → unparse → reparse) for any file containing `lazy import` statements.
pablogsal
requested review from
Eclips4,
JelleZijlstra,
isidentical and
tomasr8
as code owners
February 16, 2026 22:22
itamaro
approved these changes
Feb 16, 2026
itamaro
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Should this be covered by additional unittests?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
For now I am landing this to stop the inevitable failure in all the buildbots that build with -uall we can then add unittest later |
Sorry, something went wrong.
brijkapadia
pushed a commit
to brijkapadia/cpython
that referenced
this pull request
Feb 28, 2026
…44893) The unparser was not handling the `is_lazy` attribute on Import and ImportFrom AST nodes, causing lazy imports to be unparsed as regular imports. This broke the round-trip (parse → unparse → reparse) for any file containing `lazy import` statements.
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
…44893) The unparser was not handling the `is_lazy` attribute on Import and ImportFrom AST nodes, causing lazy imports to be unparsed as regular imports. This broke the round-trip (parse → unparse → reparse) for any file containing `lazy import` statements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unparser was not handling the is_lazy attribute on Import and
ImportFrom AST nodes, causing lazy imports to be unparsed as regular
imports. This broke the round-trip (parse → unparse → reparse) for
any file containing lazy import statements.