| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Oh, the "Run mypy on Lib/tomllib" job fails with "Name frozendict is not defined" because it runs on an older Python version which doesn't have this new built-in type: Run mypy --config-file Lib/tomllib/mypy.ini
Lib/tomllib/_parser.py:43: error: Name "frozendict" is not defined
[name-defined]
BASIC_STR_ESCAPE_REPLACEMENTS: Final = frozendict(
^~~~~~~~~~
Found 1 error in 1 file (checked 4 source files)
Error: Process completed with exit code 1.
|
Sorry, something went wrong.
|
I reverted the tomllib change to workaround the mypy issue. |
Sorry, something went wrong.
There was a problem hiding this comment.
Approving the email change only, I'm not familiar with the other code bases.
Sorry, something went wrong.
There was a problem hiding this comment.
Ok for HMAC & other hashlib-related changes (they are only tests and essentially, I wanted an immutable view of a mapping so it serves us well)
Sorry, something went wrong.
|
Oh, tests are failing 0:13:17 load avg: 10.90 [1/1/1] test_dataclasses failed (1 failure) FAIL: test_field_repr (test.test_dataclasses.TestCase.test_field_repr)Traceback (most recent call last): |
Sorry, something went wrong.
|
I'll have a look on this as soon as I've got some time |
Sorry, something went wrong.
|
I updated my branch and I updated test_dataclasses for repr(frozendict) change.
I updated repr(frozendict) of empty frozendict to: frozendict() instead of frozendict({}). |
Sorry, something went wrong.
|
LGTM |
Sorry, something went wrong.
|
Merged. Thanks for reviews. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.