FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-141510: Support frozendict in pprint by vstinner · Pull Request #144908 · python/cpython · GitHub

/ cpython Public

gh-141510: Support frozendict in pprint - #144908

Merged
vstinner merged 7 commits into
python:mainfrom
vstinner:frozendict_pprint
Feb 21, 2026
ConversationCommits (7)ChecksFiles changed
Merged

gh-141510: Support frozendict in pprint#144908
vstinner merged 7 commits into
python:mainfrom
vstinner:frozendict_pprint

Conversation

vstinner commented Feb 17, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Feb 17, 2026
Closed

vstinner commented Feb 18, 2026

Copy link
Copy Markdown
Member Author

cc @freddrake

hugovk mentioned this pull request Feb 21, 2026
Open
serhiy-storchaka self-requested a review February 21, 2026 11:03
serhiy-storchaka reviewed Feb 21, 2026
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

What about frozendict views?

Comment thread Lib/pprint.py Outdated

devdanzin commented Feb 21, 2026

Copy link
Copy Markdown
Member

frozendict views are standard dict views.

devdanzin mentioned this pull request Feb 21, 2026
Closed

vstinner commented Feb 21, 2026

Copy link
Copy Markdown
Member Author

I completed the PR. Please review again.

What about frozendict views?

I added multiple tests on keys(), values() and items().

serhiy-storchaka approved these changes Feb 21, 2026
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM if all new code is covered by tests.

Comment thread Lib/pprint.py
return "{%s}" % ", ".join(components), readable, recursive
rep = "{%s}" % ", ".join(components)
if is_frozendict:
rep = f"{object.__class__.__name__}({rep})"

serhiy-storchaka Feb 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is it covered by tests?

vstinner Feb 21, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This line is coverted by test_basic_line_wrap() and test_same_as_repr() tests. If I modify the code to raise an exception, both tests fail.

vstinner merged commit 770d354 into python:main Feb 21, 2026
49 checks passed
vstinner deleted the frozendict_pprint branch February 21, 2026 16:08

vstinner commented Feb 21, 2026

Copy link
Copy Markdown
Member Author

Merged. Thanks for reviews! Thanks for your contribution @devdanzin!

brijkapadia pushed a commit to brijkapadia/cpython that referenced this pull request Feb 28, 2026
pythongh-141510: Support frozendict in pprint (python#144908)
bb67255 
Co-authored-by: devdanzin <74280297+devdanzin@users.noreply.github.com>
This was referenced Mar 12, 2026
Closed
Merged
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
pythongh-141510: Support frozendict in pprint (python#144908)
21954f4 
Co-authored-by: devdanzin <74280297+devdanzin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

devdanzin devdanzin left review comments
serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL