FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-145006: add ModuleNotFoundError hints when a module for a differen… by FFY00 · Pull Request #145007 · python/cpython · GitHub

/ cpython Public

GH-145006: add ModuleNotFoundError hints when a module for a differen… - #145007

Merged
FFY00 merged 6 commits into
python:mainfrom
FFY00:gh-145006
Feb 25, 2026
ConversationCommits (6)ChecksFiles changed
Merged

GH-145006: add ModuleNotFoundError hints when a module for a differen…#145007
FFY00 merged 6 commits into
python:mainfrom
FFY00:gh-145006

Conversation

FFY00 commented Feb 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Member 
Python 3.15.0a6+ free-threading build (heads/main-dirty:f282f7aed91, Feb 19 2026, 17:33:04) [GCC 15.2.1 20260209] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import foo.ext
Traceback (most recent call last):
  File "<python-input-0>", line 1, in <module>
    import foo.ext
ModuleNotFoundError: No module named 'foo.ext'. Although a module with this name was found for a different Python version (ext.cpython-315-x86_64-linux-gnu.so).

bedevere-app Bot mentioned this pull request Feb 19, 2026
Closed
pythonGH-145006: add ModuleNotFoundError hints when a module for a di…
0219ab7 
…fferent ABI exists

Signed-off-by: Filipe Laíns <lains@riseup.net>

benediktjohannes commented Feb 20, 2026

Copy link
Copy Markdown
Contributor

Unforetunately, multiple checks seem to be failing, I'll have a look on this

benediktjohannes reviewed Feb 20, 2026
View reviewed changes
Comment thread Lib/traceback.py
benediktjohannes reviewed Feb 20, 2026
View reviewed changes
Comment thread Lib/traceback.py Outdated
benediktjohannes reviewed Feb 20, 2026
View reviewed changes

benediktjohannes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I guess that this should fix the failing tests

Fix deprecation warnings
49f20f6 
Signed-off-by: Filipe Laíns <lains@riseup.net>

FFY00 commented Feb 24, 2026

Copy link
Copy Markdown
Member Author

Thanks for the review @benediktjohannes! I had forgotten we deprecated passing strings to the MultiplexedPath constructor. I opted to fix it using map as I think, in this case, chaining map and filter reads a little easier than using a list comprehension to do both the type conversion and filtering together. Though this is very much a personal preference 😄

benediktjohannes commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

Thank you for the fix! You are welcome!

FFY00 added 4 commits February 24, 2026 18:22
Use SHLIB_SUFFIX in test_find_incompatible_extension_modules when ava…
1e1bc55 
…ilable

Signed-off-by: Filipe Laíns <lains@riseup.net>
Add test_incompatible_extension_modules_hint
44c765f 
Signed-off-by: Filipe Laíns <lains@riseup.net>
Fix Windows
212c02d 
Signed-off-by: Filipe Laíns <lains@riseup.net>
Show the whole extension module file name in hint
b0647c2 
Signed-off-by: Filipe Laíns <lains@riseup.net>
FFY00 merged commit 1ac9d13 into python:main Feb 25, 2026
47 checks passed

hugovk commented Feb 25, 2026

Copy link
Copy Markdown
Member

Reminder for next time, please try and keep the squashed commit message a bit tidier: 1ac9d13.

A descriptive commit body isn't necessary, but let's keep out the individual commit messages. I usually remove the whole thing via Refined GitHub.

Thanks!

FFY00 commented Feb 25, 2026

Copy link
Copy Markdown
Member Author

Ah, sorry!

Do you know the name of the Refined Github setting to remove the automatically generated squash description? I can't seem to find it.

hugovk commented Feb 25, 2026

Copy link
Copy Markdown
Member

I use the defaults, and helpfully the merge box shows, this linking to the clear-pr-merge-commit-message rule:

The description field was cleared by Refined GitHub.

brijkapadia pushed a commit to brijkapadia/cpython that referenced this pull request Feb 28, 2026
pythonGH-145006: add ModuleNotFoundError hints when a module for a di…
08059f6 
…fferen… (python#145007)

* pythonGH-145006: add ModuleNotFoundError hints when a module for a different ABI exists

Signed-off-by: Filipe Laíns <lains@riseup.net>

* Fix deprecation warnings

Signed-off-by: Filipe Laíns <lains@riseup.net>

* Use SHLIB_SUFFIX in test_find_incompatible_extension_modules when available

Signed-off-by: Filipe Laíns <lains@riseup.net>

* Add test_incompatible_extension_modules_hint

Signed-off-by: Filipe Laíns <lains@riseup.net>

* Fix Windows

Signed-off-by: Filipe Laíns <lains@riseup.net>

* Show the whole extension module file name in hint

Signed-off-by: Filipe Laíns <lains@riseup.net>

---------

Signed-off-by: Filipe Laíns <lains@riseup.net>
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
pythonGH-145006: add ModuleNotFoundError hints when a module for a di…
5fe742f 
…fferen… (python#145007)

* pythonGH-145006: add ModuleNotFoundError hints when a module for a different ABI exists

Signed-off-by: Filipe Laíns <lains@riseup.net>

* Fix deprecation warnings

Signed-off-by: Filipe Laíns <lains@riseup.net>

* Use SHLIB_SUFFIX in test_find_incompatible_extension_modules when available

Signed-off-by: Filipe Laíns <lains@riseup.net>

* Add test_incompatible_extension_modules_hint

Signed-off-by: Filipe Laíns <lains@riseup.net>

* Fix Windows

Signed-off-by: Filipe Laíns <lains@riseup.net>

* Show the whole extension module file name in hint

Signed-off-by: Filipe Laíns <lains@riseup.net>

---------

Signed-off-by: Filipe Laíns <lains@riseup.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
benediktjohannes benediktjohannes left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL