FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-145056: Let dict specific tests accept frozendict as well by rhettinger · Pull Request #145060 · python/cpython · GitHub

/ cpython Public

gh-145056: Let dict specific tests accept frozendict as well - #145060

Closed
rhettinger wants to merge 3 commits into
python:mainfrom
rhettinger:collections_any_dict
ConversationCommits (3)ChecksFiles changed
Closed

gh-145056: Let dict specific tests accept frozendict as well#145060
rhettinger wants to merge 3 commits into
python:mainfrom
rhettinger:collections_any_dict

Conversation

rhettinger commented Feb 21, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

rhettinger added skip news 3.15 pre-release feature fixes, bugs and security fixes labels Feb 21, 2026
bedevere-app Bot mentioned this pull request Feb 21, 2026
Open
skirpichev self-requested a review February 21, 2026 00:21
serhiy-storchaka self-requested a review February 21, 2026 10:55
serhiy-storchaka requested changes Feb 21, 2026
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is not ready yet.

Comment thread Lib/test/test_ordered_dict.py
d |= list(b.items())
expected = OrderedDict({0: 0, 1: 1, 2: 2, 3: 3})
self.assertEqual(a | dict(b), expected)
self.assertEqual(a | frozendict(b), expected)

serhiy-storchaka Feb 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Should not the type of the result to be tested too?

rhettinger Feb 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The existing test didn't check result type. I don't want to feature creep this edit. Reviewing and expanding the existing test strategies can be a task for another day.

serhiy-storchaka Feb 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The new tests are passed with unmodified code. Therefore they are not correct tests for this change.

Comment thread Lib/collections/__init__.py

def __or__(self, other):
if not isinstance(other, dict):
if not isinstance(other, (dict, frozendict)):

serhiy-storchaka Feb 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

What about the C implementation?

rhettinger Feb 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The C version already supported any mapping input, that is how the tests passed. But I will update the fast path to use PyAnyDict_CheckExact(arg).

Comment thread Lib/collections/__init__.py
if isinstance(other, UserDict):
return self.__class__(self.data | other.data)
if isinstance(other, dict):
if isinstance(other, (dict, frozendict)):

serhiy-storchaka Feb 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Any tests for this?

rhettinger Feb 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

No, I didn't see where the dict version was tested so left this alone.

serhiy-storchaka Feb 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Very bad. We need to add tests with dict first.

serhiy-storchaka Feb 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Well, let's leave this. There are many other missing tests for UserDict and UserList. I am working on this.

serhiy-storchaka Feb 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

#145145 will add new tests. Now there will be a place for new frozendict tests.

bedevere-app Bot commented Feb 21, 2026

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

serhiy-storchaka requested changes Feb 21, 2026
View reviewed changes
Comment thread Lib/test/test_ordered_dict.py
d |= list(b.items())
expected = OrderedDict({0: 0, 1: 1, 2: 2, 3: 3})
self.assertEqual(a | dict(b), expected)
self.assertEqual(a | frozendict(b), expected)

serhiy-storchaka Feb 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The new tests are passed with unmodified code. Therefore they are not correct tests for this change.

Comment thread Lib/collections/__init__.py
if isinstance(other, UserDict):
return self.__class__(self.data | other.data)
if isinstance(other, dict):
if isinstance(other, (dict, frozendict)):

serhiy-storchaka Feb 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Very bad. We need to add tests with dict first.

rhettinger closed this Feb 22, 2026
serhiy-storchaka mentioned this pull request Mar 22, 2026
Closed
skirpichev removed their assignment May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka requested changes
skirpichev skirpichev approved these changes

Assignees

No one assigned

Labels

3.15 pre-release feature fixes, bugs and security fixes awaiting changes skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL