gh-145118: Add frozendict support to type() - #145124
Merged
vstinner merged 3 commits intoMar 2, 2026
Merged
Conversation
eendebakpt
reviewed
Feb 22, 2026
Comment thread
Objects/typeobject.c
eendebakpt
reviewed
Feb 22, 2026
Comment thread
Objects/typeobject.c
Outdated
vstinner
reviewed
Feb 22, 2026
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
You should write a separated PR to modify str.maketrans(). It's unrelated to the type change.
Sorry, something went wrong.
vstinner
approved these changes
Mar 2, 2026
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Merged, thanks. |
Sorry, something went wrong.
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.