FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-145209: Composability of `difflib` by dg-pb · Pull Request #145210 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-145209: Composability of difflib - #145210

Open
dg-pb wants to merge 18 commits into
python:mainfrom
dg-pb:composable_difflib
ConversationCommits (18)ChecksFiles changed
Open

gh-145209: Composability of difflib#145210
dg-pb wants to merge 18 commits into
python:mainfrom
dg-pb:composable_difflib

Conversation

dg-pb commented Feb 25, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot mentioned this pull request Feb 25, 2026
Open
dg-pb requested a review from AA-Turner as a code owner March 6, 2026 03:30

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label May 7, 2026
dg-pb mentioned this pull request Oct 23, 2026
Closed
StanFromIreland reviewed Oct 23, 2026
View reviewed changes
Comment thread Doc/library/difflib.rst
>>> get_close_matches('accept', keyword.kwlist)
['except']

.. versionchanged:: 3.15

StanFromIreland Oct 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please update for 3.16, and use next.

dg-pb commented Oct 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

So I have restructured difflib here and prepared the ground for modularity - this would have solved most of the issues with functionality and paved the way for further algorithmic improvements and extensions.

Unfortunately, I see that by now there are many conflicts and people have gone on a different path. 2 things.

  1. Major. With this PR, change that has been done in gh-118150: difflib: expose autojunk flag from SequenceMatcher to public methods and functions #153959 would not have been necessary. This PR has strengthened difflib's coupling with single matcher, which is in completely opposite direction to what I was doing here.
  2. Minor. This gh-154661: Reorganize difflib documentation #154662 has restructured documentation and now it conflicts with pretty much all of restructuring that I have done here.

@encukou, what now? I am happy to retract my efforts here all together.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

StanFromIreland StanFromIreland left review comments
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL