[3.14] gh-145037: Fix Emscripten trampoline with emcc >= 4.0.19 (GH-145038) - #145283
Merged
freakboy3742 merged 1 commit intoFeb 27, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…nGH-145038) This undoes a change made as a part of PR 137470, for compatibility with EMSDK 4.0.19. It adds `emscripten_trampoline` field in `pycore_runtime_structs.h` and initializes it from JS initialization code with the wasm-gc based trampoline if possible. Otherwise we fall back to the JS trampoline. (cherry picked from commit 43fdb70) Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
miss-islington
requested review from
corona10 and
erlend-aasland
as code owners
February 26, 2026 21:45
Copy link
Copy Markdown
Contributor
|
!buildbot emscripten |
Sorry, something went wrong.
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 280dcd6 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F145283%2Fmerge The command will test the builders whose names match following regular expression: emscripten The builders matched are:
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This undoes a change made as a part of PR 137470, for compatibility with EMSDK
4.0.19. It adds emscripten_trampoline field in pycore_runtime_structs.h
and initializes it from JS initialization code with the wasm-gc based trampoline
if possible. Otherwise we fall back to the JS trampoline.
(cherry picked from commit 43fdb70)
Co-authored-by: Hood Chatham roberthoodchatham@gmail.com