gh-145299: Move __cached__ deprecation to its own section - #145374
Closed
gourijain029-del wants to merge 2 commits into
Closed
gh-145299: Move __cached__ deprecation to its own section#145374gourijain029-del wants to merge 2 commits into
gourijain029-del wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
gourijain029-del
requested review from
AA-Turner and
willingc
as code owners
February 28, 2026 23:07
The __cached__ deprecation notice was under __file__ documentation. Since __cached__ was removed in 3.15, the deprecation notice is no longer relevant and has been removed.
gourijain029-del
force-pushed
the
gh-145299-fix-cached-deprecation-location
branch
from
0d0c668 to
dc0295c
Compare
February 28, 2026 23:22
da-woods
reviewed
Mar 1, 2026
Comment thread
Doc/reference/datamodel.rst
|
|
||
| .. versionchanged:: 3.15 | ||
| ``__cached__`` is no longer set. | ||
|
|
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This doesn't look like you've moved it
Sorry, something went wrong.
Copy link
Copy Markdown
Author
There was a problem hiding this comment.
I have now properly moved the cached deprecation notice to its own dedicated section in datamodel.rst
and updated the documentation for file to remove the plural reference. Thanks for catching that!
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Now you've added docs for the removed attribute. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deprecation notice for __cached__ was incorrectly placed under the __file__ attribute documentation, making it confusing for readers.
This PR:
Fixes #145299
📚 Documentation preview 📚: https://cpython-previews--145374.org.readthedocs.build/