FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-106318: Add examples for str.isspace() docs by adorilson · Pull Request #145399 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-106318: Add examples for str.isspace() docs - #145399

Merged
hugovk merged 1 commit into
python:mainfrom
adorilson:106318.isspace
Mar 10, 2026
ConversationCommits (1)ChecksFiles changed
Merged

gh-106318: Add examples for str.isspace() docs#145399
hugovk merged 1 commit into
python:mainfrom
adorilson:106318.isspace

Conversation

adorilson commented Mar 1, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

WIP to #106318

#106318: Add examples for str.isspace() docs

📚 Documentation preview 📚: https://cpython-previews--145399.org.readthedocs.build/

bedevere-app Bot added docs Documentation in the Doc dir skip news labels Mar 1, 2026
github-project-automation Bot moved this to Todo in Docs PRs Mar 1, 2026
bedevere-app Bot mentioned this pull request Mar 1, 2026
Open
eendebakpt approved these changes Mar 1, 2026
View reviewed changes
Comment thread Doc/library/stdtypes.rst
("Separator, space"), or its bidirectional class is one of ``WS``,
``B``, or ``S``.

See also :meth:`isprintable`.

eendebakpt Mar 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I would remove the reference to isprintable here (and the reference to isspace in the docs on isprintable as well).

vstinner Mar 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ah? IMO the two methods are related and it's useful to link them together in the doc.

vstinner approved these changes Mar 4, 2026
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

hugovk added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Mar 10, 2026
hugovk merged commit 9585f50 into python:main Mar 10, 2026
47 checks passed
github-project-automation Bot moved this from Todo to Done in Docs PRs Mar 10, 2026

miss-islington-app Bot commented Mar 10, 2026

Copy link
Copy Markdown

Thanks @adorilson for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 10, 2026
pythongh-106318: Add examples for str.isspace() docs (pythonGH-145399)
ea01378 
(cherry picked from commit 9585f50)

Co-authored-by: Adorilson Bezerra <adorilson@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 10, 2026
pythongh-106318: Add examples for str.isspace() docs (pythonGH-145399)
aff027f 
(cherry picked from commit 9585f50)

Co-authored-by: Adorilson Bezerra <adorilson@gmail.com>

bedevere-app Bot commented Mar 10, 2026

Copy link
Copy Markdown

GH-145752 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Mar 10, 2026

bedevere-app Bot commented Mar 10, 2026

Copy link
Copy Markdown

GH-145753 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Mar 10, 2026
hugovk pushed a commit that referenced this pull request Mar 10, 2026
[3.14] gh-106318: Add examples for str.isspace() docs (GH-145399) (#1…
387abcc 
…45752)

Co-authored-by: Adorilson Bezerra <adorilson@gmail.com>
hugovk pushed a commit that referenced this pull request Mar 10, 2026
[3.13] gh-106318: Add examples for str.isspace() docs (GH-145399) (#1…
973323e 
…45753)

Co-authored-by: Adorilson Bezerra <adorilson@gmail.com>
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
pythongh-106318: Add examples for str.isspace() docs (python#145399)
f03d9f0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
eendebakpt eendebakpt approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL