Repository navigation
gh-145376: Fix refleak in error path of time_tzset - #145477
Merged
encukou merged 2 commits intoMar 4, 2026
Merged
encukou merged 2 commits into
encukou merged 2 commits into
Conversation
eendebakpt
requested review from
StanFromIreland,
abalkin and
pganssle
as code owners
March 3, 2026 14:56
johnslavik
reviewed
Mar 3, 2026
Comment thread
Modules/timemodule.c
Outdated
Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
StanFromIreland
approved these changes
Mar 3, 2026
StanFromIreland
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
johnslavik
approved these changes
Mar 3, 2026
sergey-miryanov
approved these changes
Mar 4, 2026
Copy link
Copy Markdown
Member
|
We have a buildbot or something that tests for refleaks, right? Is there a reason that this wasn't detected there? Is there a lack of test coverage? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Yeah, sometimes it is hard to test the fail path. Sometimes it is just an oversight. |
Sorry, something went wrong.
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.