Repository navigation
gh-144741: Fix test_frame_pointer_unwind for libpython - #145499
Merged
vstinner merged 1 commit intoMar 4, 2026
Merged
vstinner merged 1 commit into
vstinner merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Fix test_frame_pointer_unwind when Python is built with --enable-shared. Classify also libpython frames as "python".
pablogsal
approved these changes
Mar 4, 2026
Copy link
Copy Markdown
Member
|
Great catch! |
Sorry, something went wrong.
diegorusso
approved these changes
Mar 4, 2026
diegorusso
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I agree, excellent stuff!
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
The JIT failures are unrelated and should be fixed by #145496 (which increases _Py_MAX_MANAGED_STATIC_BUILTIN_TYPES to fix the issue). |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Merged. Thanks for your reviews! |
Sorry, something went wrong.
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
…145499) Fix test_frame_pointer_unwind when Python is built with --enable-shared. Classify also libpython frames as "python".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix test_frame_pointer_unwind when Python is built with --enable-shared. Classify also libpython frames as "python".