gh-141510: Don't accept frozendict in PyDict_Watch() - #145529
Merged
vstinner merged 1 commit intoMar 5, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Don't accept frozendict in PyDict_Watch() and PyDict_Unwatch(). A frozendict cannot be modified, so it's not useful to watch for modifications.
Copy link
Copy Markdown
Member
Author
|
I don't recall why I modified PyDict_Watch() and PyDict_Unwatch() to accept frozendict in my commit 696cdfc. Maybe I just replaced mechanically PyDict_Check() with PyAnyDict_Check().
If later, it becomes useful, we can modify the functions again. But I prefer to start by not accepting them. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Fidget-Spinner
approved these changes
Mar 5, 2026
Copy link
Copy Markdown
Member
Author
|
Merged. Thanks for the review @Fidget-Spinner. |
Sorry, something went wrong.
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
…5529) Don't accept frozendict in PyDict_Watch() and PyDict_Unwatch(). A frozendict cannot be modified, so it's not useful to watch for modifications.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't accept frozendict in PyDict_Watch() and PyDict_Unwatch(). A frozendict cannot be modified, so it's not useful to watch for modifications.