gh-141510: Raise TypeError in PyDict_SetItem() on frozendict - #145564
Merged
vstinner merged 1 commit intoMar 11, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
If the following functions get an unexpected frozendict, raise a TypeError with an useful error message: * PyDict_DelItem() * PyDict_DelItemString() * PyDict_Merge() * PyDict_MergeFromSeq2() * PyDict_Pop() * PyDict_PopString() * PyDict_SetDefault() * PyDict_SetDefaultRef() * PyDict_SetItem() * PyDict_SetItemString() * _PyDict_SetItem_KnownHash() * PyDict_Update() Co-Authored-by: mohsinm-dev <mohsin.mdev@gmail.com>
Copy link
Copy Markdown
Member
Author
|
This change raises a nice TypeError exception with an useful error message when a frozendict is passed to a PyDict function which tries to modify it (ex: PyDict_SetItem). The initial version of the code is based on PR gh-145123. |
Sorry, something went wrong.
corona10
reviewed
Mar 5, 2026
corona10
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Generally looks good to me, but let me take a look til this weekend.
Sorry, something went wrong.
corona10
approved these changes
Mar 11, 2026
corona10
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Merged. Thanks for the review @corona10. |
Sorry, something went wrong.
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
…ython#145564) If the following functions get an unexpected frozendict, raise TypeError instead of SystemError: * PyDict_DelItem() * PyDict_DelItemString() * PyDict_Merge() * PyDict_MergeFromSeq2() * PyDict_Pop() * PyDict_PopString() * PyDict_SetDefault() * PyDict_SetDefaultRef() * PyDict_SetItem() * PyDict_SetItemString() * _PyDict_SetItem_KnownHash() * PyDict_Update() Co-authored-by: mohsinm-dev <mohsin.mdev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the following functions get an unexpected frozendict, raise a TypeError with an useful error message: